[HOLD for payment 2024-08-14] [$250] [Payment card / Subscription] - Error message is not dismissed after entering text in the response field

@greg-schroeder

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Found when validating #44763
Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no this is new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

Account has collect workspace with an annual subscription.

Go to staging.new.expensify.com
Go to Subscription.
Click "Request early cancellation".
Without selecting a reason, click Submit.
Select a reason.
Note that the error message disappears.
Click Submit without entering response in the text field.
Enter response in the text field.

Expected Result:

The error message will be dismissed after entering text in the response field.

Actual Result:

The error message is not dismissed after entering text in the response field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6552303_1721888812694.20240725_142320.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019378d79c0bd60aef
Upwork Job ID: 1817975652284460058
Last Price Increase: 2024-07-29

Issue Owner

Current Issue Owner: @greg-schroeder

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@youssef-lr

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release2

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message is not dismissed after entering text in the response field

What is the root cause of that problem?

We just set the value and not hide the error message on text change here

What changes do you think we should make in order to solve the problem?

create handleSetNote function to set setShouldShowReasonError(false); and use it in onChangeText

    const handleSetNote = (text: string) => {
        setShouldShowReasonError(false);
        setNote(text);
    };

What alternative solutions did you explore? (Optional)

Reviewing label has been removed, please complete the "BugZero Checklist".

@allroundexperts

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Payment card / Subscription] - Error message is not dismissed after entering text in the response field #46641

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

@allroundexperts requires payment through NewDot Manual Requests
@JKobrynski does not require payment (Contractor)

@allroundexperts

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Regression test

Sign in to an account that has a collect workspace with an annual subscription.
Go to Subscription and click "Request early cancellation".
Without selecting a reason, click Submit.
Verify that an error message appears.
Select a reason.
Verify that the error message disappears.
Click Submit without entering response in the text field.
Verify that an error appears.
Enter response in the text field.
Verify that the error message will be dismissed after entering text in the response field.

Do we 👍 or 👎 ?

This is a regression follow-up, so no payments are due in this issue tomorrow. I've filed the regression test above as well. Closing for now. Please reopen if I've missed anything.

@greg-schroeder

@greg-schroeder I was not involved in the previous issue (if there was any). I think my payment is pending here for the review.

@allroundexperts

payment summary:

@allroundexperts okay thanks! in that case you can make a manual request via ND for $250 for the reviewer role

@allroundexperts

$250 approved for @allroundexperts

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-14] [$250] [Payment card / Subscription] - Error message is not dismissed after entering text in the response field #46182

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

32 remaining items

Regression test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-14] [$250] [Payment card / Subscription] - Error message is not dismissed after entering text in the response field #46182

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 25, 2024

melvin-bot commented on Jul 25, 2024

github-actions commented on Jul 25, 2024

m-natarajan commented on Jul 25, 2024

nyomanjyotisa commented on Jul 25, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

32 remaining items

melvin-bot commented on Aug 7, 2024

melvin-bot commented on Aug 7, 2024

melvin-bot commented on Aug 7, 2024

allroundexperts commented on Aug 11, 2024

Regression test

greg-schroeder commented on Aug 13, 2024

allroundexperts commented on Aug 15, 2024

greg-schroeder commented on Aug 15, 2024

JmillsExpensify commented on Oct 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions