Skip to content

IOU - "Next steps" comment is not correct after approving report #46157

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.11-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): vdargentotest+web072424@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Team
Slack conversation:

Found while executing PR #45160

Action Performed:

Pre-requisite: create a collect workspace and invite an employee.

  1. As the admin, go to OD and set "Scheduled Submit" enabled in the "Reports" section, set it as "Manually".
  2. Set the Approval Mode to "Submit and Approve" on the "Members" section.
  3. As the employee, go to workspace chat on ND and submit a money request.
  4. As the admin on ND, got to the employee's workspace chat and open the report.
  5. Click on the "Approve" button.

Expected Result:

Next steps comment should say "Waiting for [Admin] to pay expense(s)" and an hourglass accompanying icon.

Actual Result:

Next steps comment says "No further action required!" and a checkmark accompanying icon

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • [] Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6552118_1721869116392.bandicam_2024-07-24_14-08-08-218.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 25, 2024
  2. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mvtglobally commented on Jul 25, 2024

    @mvtglobally
    Author

    We think this is related to #wave-collect - Release 1

  4. francoisl commented on Jul 25, 2024

    @francoisl
    Contributor

    This is also happening on production so not going to make this a deploy blocker. We had an issue in the past few days where the web production deploy wasn't actually deployed, so the production version you were seeing was an older one. It's fixed now.

    image
  5. JmillsExpensify commented on Jul 30, 2024

    @JmillsExpensify
    Contributor

    I'm not certain that this is a bug. What's the configuration of the workspace on NewDot? Is reimbursement enabled in the workspace?

  6. melvin-bot commented on Jul 30, 2024

    @melvin-bot

    @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

  7. adelekennedy commented on Aug 1, 2024

    @adelekennedy
    Contributor

    yikes - this got assigned to me when i was already ooo and I missed it. Bump on @JmillsExpensify question @mvtglobally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions