LHN - Display chats with an existing draft under pinned chats in LHN

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to a conversation that's not on the top of LHN
2. Write something in the compose box.
3. Navigate away from the chat

Expected Result:

Conversation with a draft message should be displayed on the top of LHN for visibility

Actual Result:

Conversation is not displayed on the top and can be easily lost in the LHN conversation list.

Workaround:

User can manually look for the conversation with the drafted message.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.85-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @rafecolton https://expensify.slack.com/archives/C01GTK53T8Q/p1628786564265600

Chats with draft messages no longer show at the top of the LHN below pinned chats. Unless I missed a conversation somewhere, this is a regression. Edit: I'm on macOS desktop 1.0.82-7

[MelvinBot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

By looking at the code in

App/src/libs/OptionsListUtils.js

Lines 387 to 428 in ff62078

	if (includeRecentReports) {
	for (let i = 0; i < allReportOptions.length; i++) {
	// Stop adding options to the recentReports array when we reach the maxRecentReportsToShow value
	if (recentReportOptions.length > 0 && recentReportOptions.length === maxRecentReportsToShow) {
	break;
	}
	const reportOption = allReportOptions[i];
	// Skip if we aren't including multiple participant reports and this report has multiple participants
	if (!includeMultipleParticipantReports && !reportOption.login) {
	continue;
	}
	// Check the report to see if it has a single participant and if the participant is already selected
	if (reportOption.login && _.some(loginOptionsToExclude, option => option.login === reportOption.login)) {
	continue;
	}
	// Finally check to see if this option is a match for the provided search string if we have one
	const {searchText, participantsList, isDefaultChatRoom} = reportOption;
	const participantNames = getParticipantNames(participantsList);
	if (searchValue && !isSearchStringMatch(searchValue, searchText, participantNames, isDefaultChatRoom)) {
	continue;
	}
	// If the report is pinned and we are using the option to display pinned reports on top then we need to
	// collect the pinned reports so we can sort them alphabetically once they are collected
	if (prioritizePinnedReports && reportOption.isPinned) {
	pinnedReportOptions.push(reportOption);
	} else if (prioritizeIOUDebts && reportOption.hasOutstandingIOU && !reportOption.isIOUReportOwner) {
	iouDebtReportOptions.push(reportOption);
	} else {
	recentReportOptions.push(reportOption);
	}
	// Add this login to the exclude list so it won't appear when we process the personal details
	if (reportOption.login) {
	loginOptionsToExclude.push({login: reportOption.login});
	}
	}
	}

I can see that we have to choose one option to prioritize: iou debt or pinned, and now we are adding with draft comment. The way it is implemented now, looks like the prioritized is exclusive, if I prioritize by pinned, then 'iou debt' won't be prioritized.

How do we want the reports with draft comment to appear? if it is prioritized by 'iou debt', then the chat with draft comments should be right below the 'iou debt'? or on top?

Wouldn't it be better to be able to have also a way of keeping things in a prioritization like:

1. pinned
2. iou debt
3. drafts
4. all the rest

And then the user, in the settings, can check or uncheck if they want to have categories like iou debt prioritized or not. If a user uncheck iou debt as a priority, then these reports get mixed git 'all the rest', leaving the reports in the following order:

1. pinned
2. drafts
3. all the rest

[MelvinBot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[aldo-expensify]

In my opinion, this can be performed by an external because it seems to be only UI stuff