Repository navigation
Search - Hold option is present for expense that is still scanning on Search page #46078
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.11-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat
- Submit a scan expense
- Go to transaction thread
- Click on the report header
- Note that Hold option is not present when the receipt is still scanning
- Go to Search
- Select the scanning expense
- Click on the dropdown
Expected Result:
Hold option will not be present for expense that is still scanning
Actual Result:
Hold option is present for expense that is still scanning on Search page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Jul 23, 2024
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 23, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
stitesExpensify commentedon Jul 23, 2024
@luacmartins looks like you have been working on this feature. Would you mind taking over this issue?
luacmartins commentedon Jul 23, 2024
Sure I can work on this
luacmartins commentedon Jul 23, 2024
I don't think this is a blocker. Worst case the request to Hold will fail and users might be slightly confused. Next, it seems like we have a bunch of conditions in App that are not enforced by the API. I think we should enforce these in the API as well so I'll work on a PR to add this conditions to Auth. cc @robertjchen
stitesExpensify commentedon Jul 23, 2024
Makes sense to me. Thanks!
luacmartins commentedon Jul 26, 2024
PR in review
melvin-bot commentedon Aug 2, 2024
@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
luacmartins commentedon Aug 5, 2024
this is done!