[HOLD for payment 2024-08-07] [$250] Workspace - Profile page is not grayed out when workspace is created offline and name is edited

@kadiealexander

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #45820

Action Performed:

Log in with any account.
Go offline.
Create a new workspace.
Navigate to profile > Change the name of the workspace while offline.
Observe the profile page after changing the name

Expected Result:

The profile page is grayed out

Actual Result:

The profile page is not grayed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6550619_1721747216180.2024-07-23_17_53_43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018594720711f70e58
Upwork Job ID: 1815796234833602525
Last Price Increase: 2024-07-23
Automatic offers:

suneox | Contributor | 103236301
huult | Contributor | 103249686

Issue Owner

Current Issue Owner: @kadiealexander

@kadiealexander

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bondydaa

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Issue is not reproducible in Production:

bandicam.2024-07-23.19-37-57-636.mp4

We think that this bug might be related to #wave-collect - Release 1

Reviewing label has been removed, please complete the "BugZero Checklist".

@suneox

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix profile page not greyed out #46130

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

- @suneox requires payment automatic offer (Contributor)
- @huult requires payment automatic offer (Contributor)

@suneox

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@suneox] The PR that introduced the bug has been identified. Link to the PR:
[@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@suneox] Determine if we should create a regression test for this bug.
[@suneox] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@suneox

BugZero Checklist

[@suneox] The PR that introduced the bug has been identified. Link to the PR: The PR #45820 might have triggered this issue, but it wasn’t the root cause. The root cause is that when creating a workspace in offline mode, the pending field is not set and which is an existing issue. Therefore, I don’t think PR #45820 is responsible for this.
[@suneox] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@suneox] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@suneox] Determine if we should create a regression test for this bug. No, we don’t need a regression test for it since it’s a missing implementation case that we’ve already handled.

@kadiealexander

Hey @kadiealexander, due to identifying the pull request that introduced this issue, I am eligible for payment?

Thanks

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-07] [$250] Workspace - Profile page is not grayed out when workspace is created offline and name is edited #46053

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

41 remaining items

BugZero Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-07] [$250] Workspace - Profile page is not grayed out when workspace is created offline and name is edited #46053

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 23, 2024

melvin-bot commented on Jul 23, 2024

github-actions commented on Jul 23, 2024

lanitochka17 commented on Jul 23, 2024

lanitochka17 commented on Jul 23, 2024

41 remaining items

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

suneox commented on Aug 7, 2024

BugZero Checklist

Tony-MK commented on Aug 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions