[$250] Thread - App shows join button after user joined offline

@brunovjk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4753350
Email or phone of affected tester (no customers): bezawitgebremichael+100@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team *

Action Performed:

Navigate to staging.new.expensify.com
Click on FAB
Click on start chat
Insert an email address and start a chat
Send a message
Hover over the message and click on reply in thread
Send some messages
Open the network tab and go offline
Click on thread header
Click on leave
Click on Join
Go online

Expected Result:

The user stays joined back in the thread

Actual Result:

The join button reappears again and user has to click join again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6549717_1721667673800.bandicam_2024-07-22_19-54-35-010.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0114c22d59f2094554
Upwork Job ID: 1815812057496731128
Last Price Increase: 2024-07-23

Issue Owner

Current Issue Owner: @brunovjk

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@srikarparsi

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think this issue might be related to the #vip-vsb.

Production

Recording.2636.mp4

At first glance, this seems like a frontend issue 🤔 I see LeaveRoom was called when the user got back online but maybe we should have also called the Api command to rejoin the thread?

@brunovjk

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating a thread, if a user was to go offline then leave the thread and then rejoin, the join button will appear on the screen when it is not supposed to be there.

What is the root cause of that problem?

When the user is brought back online the Sequential Queue processes the requests that weren't able to be made while the user is offline.
This means:
User leaves thread -> User rejoins thread
In that order.
So after the User Left Thread request, there is a period that the User Rejoined Thread request had not been completed.

What changes do you think we should make in order to solve the problem?

Add a pending field to our notification update function so we have a flag to look for while we're processing actions.
src/libs/actions/Report.ts

    const optimisticData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {
                notificationPreference: newValue,
                pendingFields: {
                    notificationPreference: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE
                }
            },
        },
    ];
    const successData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {
                pendingFields: {
                    notificationPreference: null
                }
            },
        },
    ];

Then modify our canJoin boolean to read that flag and be patient.
src/pages/home/HeaderView.tsx

    const isPendingNotificationUpdate = report?.pendingFields?.notificationPreference
    const canJoin = useMemo(() => {
        if (isPendingNotificationUpdate) {
            return false
        }
        return ReportUtils.canJoinChat(report, parentReportAction, policy);
    }, [isPendingNotificationUpdate])

Here is a test branch with my changes

What alternative solutions did you explore? (Optional)

N/A

@mountiny

To clarify from the issue body, the join button does disappear after a moment. The leave button isn't currently in prod so it's a little difficult to compare. @mountiny do you know if this is expected with the sequential queue or should this be fixed?

Screen.Recording.2024-07-24.at.4.30.02.AM.mov

@mountiny

If @mountiny confirm "... sequential queue ... should this be fixed" I think we can go with @Zakpak0's proposal, I tested they branch and LGTM.

🎀👀🎀 C+ reviewed

@srikarparsi

Current assignee @srikarparsi is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

Personally, in my three weeks contributing so far, I think this is the third time I've come across an offline/online issue where the queue is processing causing state to repeatedly re-render. Sometimes it's handled and sometimes it isn't. It makes me wish Onyx had an offline state and the sequential queue was a plugin that informs Onyx when it's empty and it's safe to output the results.
In the comments about the queue it mentions that they're run in order so that the expect results turns out exactly as the user input it while offline. And it makes sense, calculating an end result and simply displaying that might create confusion.
But I'm kind of tempted to crack open the code and try anyway for fun 😂

Thanks for the proposals so far. Can you identify which PR from the checklist caused the regression? Anyway, going to demote as a polish issue since it's for offline behavior that doesn't break any critical flow.

I think this is happening as we process the API commands in the backend and we queue the relevant onyx updates. First, the app processes, leaving the thread so it gets hidden and then it joins again.

I think we do not have to worry about this one too much and might even close it

I agree, closing this one out since the expected behavior (the join button not showing) does occur, it just takes a second because of the sequential queue.

Navigation Menu

Repository navigation

[$250] Thread - App shows join button after user joined offline #46004

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

6 remaining items

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Thread - App shows join button after user joined offline #46004

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 23, 2024

melvin-bot commented on Jul 23, 2024

github-actions commented on Jul 23, 2024

izarutskaya commented on Jul 23, 2024

izarutskaya commented on Jul 23, 2024

MariaHCD commented on Jul 23, 2024

6 remaining items

melvin-bot commented on Jul 23, 2024

Zakpak0 commented on Jul 24, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

srikarparsi commented on Jul 24, 2024

brunovjk commented on Jul 24, 2024

melvin-bot commented on Jul 24, 2024

Zakpak0 commented on Jul 24, 2024

francoisl commented on Jul 24, 2024

mountiny commented on Jul 25, 2024

srikarparsi commented on Jul 29, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions