[HOLD for payment 2024-08-02] [$250] Dupe detect - Merchant field is empty on the confirmation page when there is info on merchant

@twisterdotcom

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit two expenses with same content for every field (amount, description, merchant and category)
Go to transaction thread of any expense
Click Review duplicates
Select Keep this one (any)
Proceed to confirmation page

Expected Result:

All the fields will reflect the correct information on the confirmation page

Actual Result:

Merchant field is empty on the confirmation page when there is info on merchant field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6548605_1721561004558.bandicam_2024-07-21_19-11-39-312.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a0550d2189cf44a1
Upwork Job ID: 1815322514359268142
Last Price Increase: 2024-07-22

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@francoisl

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release 2

Proposal

Please re-state the problem that we are trying to solve in this issue.

Merchant field is empty on the confirmation page when there is info on merchant field.

What is the root cause of that problem?

With merchant field, we always use:

App/src/libs/TransactionUtils.ts

Line 905 in f3a8f73

const allFieldsAreEqual = transactions.every((item) => keys.every((key) => item?.[key] === firstTransaction?.[key]));

but keys is ["modifiedMerchant", "merchant"].
So firstTransaction?["modifiedMerchant"] can be "".

What changes do you think we should make in order to solve the problem?

We should update:

App/src/libs/TransactionUtils.ts

Line 905 in f3a8f73

const allFieldsAreEqual = transactions.every((item) => keys.every((key) => item?.[key] === firstTransaction?.[key]));

to:

                    if (fieldName === 'merchant') {
                        keep[fieldName] = isEmpty(firstTransaction?.[keys[0]]) ? firstTransaction?.[keys[1]] : firstTransaction?.[keys[0]];
                    } else {
                        keep[fieldName] = firstTransaction?.[keys[0]];
                    }

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Polish: Dupe detection #45890

If no regressions arise, payment will be issued on 2024-08-02. 🎊

@mountiny

@mountiny or @pecanoro who is due payment here? Just @parasharrajat for reviewing #45890?

@parasharrajat

Payment Summary:

@parasharrajat paid $250 via NewDot Manual Request (Reviewer)

Payment requested as per #45865 (comment)

@parasharrajat

$250 approved for @parasharrajat

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-02] [$250] Dupe detect - Merchant field is empty on the confirmation page when there is info on merchant #45865

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-02] [$250] Dupe detect - Merchant field is empty on the confirmation page when there is info on merchant #45865

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 21, 2024

melvin-bot commented on Jul 21, 2024

github-actions commented on Jul 21, 2024

lanitochka17 commented on Jul 21, 2024

dominictb commented on Jul 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

24 remaining items

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

twisterdotcom commented on Aug 2, 2024

twisterdotcom commented on Aug 2, 2024

parasharrajat commented on Aug 3, 2024

JmillsExpensify commented on Aug 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions