Skip to content

[HOLD for payment 2024-08-05] [$250] Dupe detect - Distance field is not disabled and not here page opens after changing distance #45833

Closed
Closed
[HOLD for payment 2024-08-05] [$250] Dupe detect - Distance field is not disabled and not here page opens after changing distance#45833
Assignees
parasharrajatRachCHopkinsmountinyc3024
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@m-natarajan
m-natarajan
opened on Jul 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.10-2
Reproducible in staging ?: Y
Reproducible in production?: No new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two same distance expenses (same distance).
  4. Go to transactiont thread of any expense.
  5. Click Review duplicates.
  6. Click Keep this one.
  7. Proceed to confirmation page.
  8. Click on the distance field.
  9. Change the distance.
  10. Click Confirm.

Expected Result:

In Step 8, distance field should be disabled.

Actual Result:

In Step 8, distance field is not disabled.
After changing the distance and confirming it, app opens not here page (Step 10).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6547831_1721455965852.20240720_140844.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0184066b98a5cfeddb
  • Upwork Job ID: 1814753910382559620
  • Last Price Increase: 2024-07-23
  • Automatic offers:
    • c3024 | Reviewer | 103200665
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. m-natarajan
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 20, 2024
  2. melvin-bot
    assigned
    RachCHopkins
    on Jul 20, 2024

  3. melvin-bot commented on Jul 20, 2024

    @melvin-bot
    melvin-botBot
    on Jul 20, 2024 – with Melvin Bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot
    assigned
    iwiznia
    on Jul 20, 2024

  5. melvin-bot commented on Jul 20, 2024

    @melvin-bot
    melvin-botBot
    on Jul 20, 2024 – with Melvin Bot

    Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Jul 20, 2024

  7. github-actions commented on Jul 20, 2024

    @github-actions
    github-actionsBot
    on Jul 20, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. mountiny commented on Jul 20, 2024

    @mountiny
    mountiny
    on Jul 20, 2024
    Contributor

    cc @pecanoro @JmillsExpensify @parasharrajat

  9. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 20, 2024

  10. melvin-bot commented on Jul 20, 2024

    @melvin-bot
    melvin-botBot
    on Jul 20, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~0184066b98a5cfeddb

  11. 42 remaining items

  12. melvin-bot commented on Jul 29, 2024

    @melvin-bot
    melvin-botBot
    on Jul 29, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat / @c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat / @c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat / @c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat / @c3024] Determine if we should create a regression test for this bug.
    • [@parasharrajat / @c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. JmillsExpensify
    added this to #expensify-bugson Jul 30, 2024
  14. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Aug 5, 2024

  15. c3024 commented on Aug 8, 2024

    @c3024
    c3024
    on Aug 8, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR: This was not a bug introduced by a PR. It was known when working on the previous PR which did not include these changes.
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    • [@c3024] Determine if we should create a regression test for this bug. Yes
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Go to a workspace chat
    2. Submit two identical distance requests (identical waypoints) to this workspace chat.
    3. Notice the review duplicate button pops up.
    4. Click Review Duplicate.
    5. Click Keep this one for any one transaction on the review page.
    6. Go through the flow till Confirm page.
    7. Click Distance field on Confirm page.
    8. Verify that the Distance field is not editable and no edit page opens up.
  16. melvin-bot
    added
    Overdue
    on Aug 8, 2024

  17. mountiny commented on Aug 8, 2024

    @mountiny
    mountiny
    on Aug 8, 2024
    Contributor

    I believe the summary is to $250 to @parasharrajat and to @c3024

  18. melvin-bot commented on Aug 8, 2024

    @melvin-bot
    melvin-botBot
    on Aug 8, 2024 – with Melvin Bot

    @parasharrajat, @RachCHopkins, @mountiny, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  19. RachCHopkins commented on Aug 8, 2024

    @RachCHopkins
    RachCHopkins
    on Aug 8, 2024
    Contributor

    Payment Summary:

    Contributor: @c3024 paid $250 via Upwork

    Contributor+: @parasharrajat due $250 via NewDot

    Upwork job here

  20. RachCHopkins
    closed this as completedon Aug 8, 2024
  21. github-project-automation
    moved this to Done in #expensify-bugson Aug 8, 2024
  22. melvin-bot
    removed
    Overdue
    on Aug 8, 2024

  23. RachCHopkins commented on Aug 12, 2024

    @RachCHopkins
    RachCHopkins
    on Aug 12, 2024
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  24. parasharrajat commented on Aug 30, 2024

    @parasharrajat
    parasharrajat
    on Aug 30, 2024
    Member

    Payment requested as per #45833 (comment)

  25. JmillsExpensify commented on Sep 2, 2024

    @JmillsExpensify
    JmillsExpensify
    on Sep 2, 2024
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions