Skip to content

[Awaiting Payment Request] [$125] Dupe detection -Not here page opens after navigating to confirm page by link and confirming it #45832

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Submit two same expenses (same amount and merchant)
  4. Go to transactiont thread of any expense
  5. Click Review duplicates
  6. Click Keep this one (any)
  7. Proceed to confirmation page
  8. Copy the link to confirmation page
  9. Go to Account settings > Troubleshoot > Clear cache and restart > Reset and refresh
  10. Navigate to the confirmation page via link
  11. Click Confirm

Expected Result:

After confirming the review, app will open the transaction thread

Actual Result:

After confirming the review, app redirects to not here page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547830_1721455455619.20240720_135327.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01156fb1121250d6e8
  • Upwork Job ID: 1814753798615808236
  • Last Price Increase: 2024-07-20
  • Automatic offers:
    • dominictb | Contributor | 103215058
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 20, 2024
  2. github-actions commented on Jul 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. mountiny commented on Jul 20, 2024

    @mountiny
    Contributor
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 20, 2024
  6. changed the title [-]Dupe detection -Not here page opens after navigating to confirm page by link and confirming it[/-] [+][$250] Dupe detection -Not here page opens after navigating to confirm page by link and confirming it[/+] on Jul 20, 2024
  7. melvin-bot commented on Jul 20, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 20, 2024
  9. melvin-bot commented on Jul 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

  10. parasharrajat commented on Jul 20, 2024

    @parasharrajat
    Member

    This needs to be handled or we have to block confirm page direct link.

  11. 41 remaining items

  12. garrettmknight commented on Aug 5, 2024

    @garrettmknight
    Contributor

    Payment Summary:

  13. garrettmknight commented on Aug 5, 2024

    @garrettmknight
    Contributor

    @parasharrajat can you finish the checklist when you get the chance?

  14. parasharrajat commented on Aug 6, 2024

    @parasharrajat
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Go to NewDot.
    2. Go to workspace chat.
    3. Submit two same expenses (same amount and merchant).
    4. Go to transaction thread of any expense.
    5. Click Review duplicates.
    6. Click Keep this one (any).
    7. Proceed to confirmation page.
    8. Copy the link to confirmation page.
    9. Go to Account settings > Troubleshoot > Clear cache and restart > Reset and refresh.
    10. Navigate to the confirmation page via link.

    Verify that: The RHP will show not found view

    Do you agree 👍 or 👎 ?

  15. garrettmknight commented on Aug 7, 2024

    @garrettmknight
    Contributor

    QA is up - just waiting on payment request for @parasharrajat

  16. changed the title [-][HOLD for payment 2024-08-02] [$125] Dupe detection -Not here page opens after navigating to confirm page by link and confirming it[/-] [+][Awaiting Payment Request] [$125] Dupe detection -Not here page opens after navigating to confirm page by link and confirming it[/+] on Aug 7, 2024
  17. parasharrajat commented on Aug 7, 2024

    @parasharrajat
    Member

    @garrettmknight feel free to close it. I will request it later.

  18. parasharrajat commented on Aug 30, 2024

    @parasharrajat
    Member

    Payment requested as per #45832 (comment)

  19. JmillsExpensify commented on Sep 2, 2024

    @JmillsExpensify
    Contributor

    $125 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions