[HOLD for payment 2024-08-02] Dupe detection - Confirm button is below the content instead of page bottom

@sonialiap

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #42571
Version Number: 9.0.10-2
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Preconditon:

Device font size may need to be reduced.

Launch New Expensify app.
Go to workspace chat.
Submit two same expenses (same amount and merchant).
Go to transaction thread of any expense.
Tap Review duplicates.
Tap Keep this one (any).
Proceed to confirmation page.

Expected Result:

Confirm button will be docked to the bottom.

Actual Result:

Confirm button is below the content.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6547713_1721437274135.Screen_Recording_20240720_085209_New_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sonialiap

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@grgia

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

This can be handled here. Posting my proposal from there incase we decide to fix this separately.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detection - Green Confirm button is shorter in width

What is the root cause of that problem?

There are two issues here.:

Confirmation width/height is shorter.

large prop isn't passed to Button.

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 83 to 88 in fa738c6

    
           <Button 
        
               text={translate('common.confirm')} 
        
               success 
        
               style={[styles.ph5, styles.mt2]} 
        
               onPress={mergeDuplicates} 
        
           />

Confirmation button isn't at the bottom

ScrollView content container doesn't take full available height.
We have applied styles.mt2 instead of styles.auto to Button element.

What changes do you think we should make in order to solve the problem?

We should add large prop to Button element.
We need to pass contentContainerStyle={styles.flex1} to ScrollView.
Replace styles.mt2 with styles.auto on Button element.

What alternative solutions did you explore? (Optional)

We can remove style={styles.mb3} from ScrollView and add contentContainerStyle={styles.flex1}.
Wrap Button with FixedFooter and apply style={[styles.mtAuto]} to `FixedFooter.
Remove style prop from Button or only keep margin top if required.

Result

Before fix

Monosnap (185) New Expensify 2024-07-20 09-38-58

After fix

Monosnap (185) New Expensify 2024-07-20 09-38-36

Reviewing label has been removed, please complete the "BugZero Checklist".

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Polish: Dupe detection #45890

If no regressions arise, payment will be issued on 2024-08-02. 🎊

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@pecanoro

@pecanoro @parasharrajat looks like payment will be handled here, is that correct?

Yes, let's close it.

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-02] Dupe detection - Confirm button is below the content instead of page bottom #45831

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

This can be handled here. Posting my proposal from there incase we decide to fix this separately.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Before fix

After fix

17 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Button
	text={translate('common.confirm')}
	success
	style={[styles.ph5, styles.mt2]}
	onPress={mergeDuplicates}
	/>

[HOLD for payment 2024-08-02] Dupe detection - Confirm button is below the content instead of page bottom #45831

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 20, 2024

github-actions commented on Jul 20, 2024

melvin-bot commented on Jul 20, 2024

Krishna2323 commented on Jul 20, 2024

This can be handled here. Posting my proposal from there incase we decide to fix this separately.

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Before fix

After fix

17 remaining items

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

sonialiap commented on Aug 2, 2024

parasharrajat commented on Aug 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions