[HOLD for payment 2024-08-01] [$125] [Payment card / Subscription] Make payment card only display last four digits

@CortneyOfstad

Problem

Right now when you add a payment card to the new subscription page, it shows the 16 characters instead of just four:

It should show just the last four:

Solution

Lets fix this by only showing the last four digits in the subscription page.

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a9042029c460e7a0
Upwork Job ID: 1811455490190961117
Last Price Increase: 2024-07-11

Issue Owner

Current Issue Owner: @CortneyOfstad / @isabelastisser

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Job added to Upwork: https://www.upwork.com/jobs/~01a9042029c460e7a0

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Not overdue.

@sobitneupane

Hey @sobitneupane, please complete the BZ list above. Thanks!

@sobitneupane

Payment Summary

Upwork Job

Reviewer: @sobitneupane owed $250 via NewDot
Reviewer: @tienifr owed $250 via NewDot

BugZero Checklist (@isabelastisser)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1811455490190961117/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#44072

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#44072 (comment)

[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not required.

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#45309 (comment)

Regression Test Proposal:

Go to /settings/subscription.
Add a new card if there is no.
Verify card title displays only last four digits of your card.

Do we agree 👍 or 👎

@blimpich

@blimpich, can you please review the regression test above? Thanks!

@sobitneupane

Payment summary:

C+ review @sobitneupane owed $250 via NewDot
Contributor @tienifr owed $250 via NewDot

All set.

@sobitneupane

$250 approved for @sobitneupane based on this summary.

@tienifr

$250 approved for @tienifr

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-01] [$125] [Payment card / Subscription] Make payment card only display last four digits #45309

Problem

Solution

53 remaining items

Payment Summary

BugZero Checklist (@isabelastisser)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-01] [$125] [Payment card / Subscription] Make payment card only display last four digits #45309

Description

Problem

Solution

Activity

melvin-bot commented on Jul 11, 2024

melvin-bot commented on Jul 11, 2024

melvin-bot commented on Jul 11, 2024

53 remaining items

isabelastisser commented on Jul 31, 2024

isabelastisser commented on Aug 1, 2024

melvin-bot commented on Aug 1, 2024

Payment Summary

BugZero Checklist (@isabelastisser)

sobitneupane commented on Aug 5, 2024

sobitneupane commented on Aug 5, 2024

isabelastisser commented on Aug 5, 2024

isabelastisser commented on Aug 5, 2024

isabelastisser commented on Aug 6, 2024

garrettmknight commented on Sep 2, 2024

garrettmknight commented on Sep 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions