Repository navigation
[HOLD for payment 2024-08-01] [$125] Add note to clarify the workspace join link functionality #45303
Description
### Problem
Coming from here, we have agreed that on the workspace share page, we do not provide enough details for the admin about what the link/QR code does.
The link will allow users to join the workspace upon visiting while being signed in. A message will appear in the admins room for each join request to confirm the addition (unless its a domain controlled account in which case we pre-approve the requests but I think we can omit that information).
Solution
Lets add some message to the share page that will make this clear, maybe with some icon/ illustration too
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015304db5f2b46c0a1
- Upwork Job ID: 1811770909332799477
- Last Price Increase: 2024-07-12
- Automatic offers:
- dominictb | Contributor | 103094166
- DylanDylann | Contributor | 103815612
Activity
melvin-bot commentedon Jul 11, 2024
Triggered auto assignment to @shmaxey (
Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.melvin-bot commentedon Jul 11, 2024
Triggered auto assignment to @miljakljajic (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.melvin-bot commentedon Jul 11, 2024
Triggered auto assignment to @shawnborton (
Design), see these Stack Overflow questions for more details.melvin-bot commentedon Jul 11, 2024
41 remaining items
miljakljajic commentedon Jul 31, 2024
payment due tomorrow, not overdue
miljakljajic commentedon Jul 31, 2024
@dominictb will we need a regression test?
dominictb commentedon Aug 1, 2024
@miljakljajic I don't think we need regression test.
miljakljajic commentedon Aug 1, 2024
paid in upwork
DylanDylann commentedon Sep 4, 2024
@miljakljajic I reviewed this PR. Should I get compensation for this issue?
melvin-bot commentedon Sep 4, 2024
📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
mountiny commentedon Sep 4, 2024
$125 to @DylanDylann too
miljakljajic commentedon Sep 4, 2024
Thanks for flagging @mountiny !
@DylanDylann - accept the offer and we'll pay right away. Apologies for not catching this.
DylanDylann commentedon Sep 5, 2024
@miljakljajic Done, thanks for helping 🙏
miljakljajic commentedon Sep 6, 2024
Paid! :)