[HOLD for payment 2024-07-26] [$125] Expensify Card - There are two error messages when trying to proceed without a limit

@jliexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.6-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings > Expensify Card (enable in More features)
Click Issue new card
Proceed to Step 4 - Set a limit
Click Next without entering anything

Expected Result:

There will be one error message when trying to proceed without a limit

Actual Result:

There are two error messages when trying to proceed without a limit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6538913_1720700812914.20240711_202403.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018df7767f83b2a4f8
Upwork Job ID: 1811791404789871853
Last Price Increase: 2024-07-12
Automatic offers:

DylanDylann | Reviewer | 103096366
nkdengineer | Contributor | 103096369

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

@jliexpensify

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jliexpensify

@jliexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 2

@mountiny

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are two error messages when trying to proceed without a limit

What is the root cause of that problem?

We don't pass shouldHideFixErrorsAlert into FormProvider to hide the fix error alert. Then we have two errors, one is the amount input error, and one is the form error.

App/src/pages/workspace/card/issueNew/LimitStep.tsx

Line 80 in 105dce5

<FormProvider

What changes do you think we should make to solve the problem?

Pass shouldHideFixErrorsAlert as true into FormProvider as we do in other places that use AmountForm input

App/src/pages/workspace/card/issueNew/LimitStep.tsx

Line 80 in 105dce5

<FormProvider

What alternative solutions did you explore? (Optional)

Reviewing label has been removed, please complete the "BugZero Checklist".

@DylanDylann

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: There are two error messages when trying to proceed without a limit #45388

If no regressions arise, payment will be issued on 2024-07-26. 🎊

For reference, here are some details about the assignees on this issue:

@DylanDylann requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@nkdengineer

Payment Summary

C: @nkdengineer $125

Upwork job

@DylanDylann

@DylanDylann will be paid separately for the entire project

Checklist is not required here as we are working on this new feature which caused this bug

Thanks Vit, fixed summary!

Paid and job closed!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-26] [$125] Expensify Card - There are two error messages when trying to proceed without a limit #45268

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make to solve the problem?

What alternative solutions did you explore? (Optional)

30 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-26] [$125] Expensify Card - There are two error messages when trying to proceed without a limit #45268

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 11, 2024

lanitochka17 commented on Jul 11, 2024

lanitochka17 commented on Jul 11, 2024

melvin-bot commented on Jul 11, 2024

github-actions commented on Jul 11, 2024

nkdengineer commented on Jul 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make to solve the problem?

What alternative solutions did you explore? (Optional)

30 remaining items

melvin-bot commented on Jul 19, 2024

melvin-bot commented on Jul 19, 2024

melvin-bot commented on Jul 19, 2024

jliexpensify commented on Jul 23, 2024

mountiny commented on Jul 23, 2024

jliexpensify commented on Jul 23, 2024

jliexpensify commented on Jul 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions