Skip to content

[HOLD for payment 2024-08-09] [$250] Android - Accounting-Confirm button doesn't work while keyboard is up #45193

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #44921

Action Performed:

Pre-requisite

  • Collect workspace with accounting enabled
  • NetSuite beta enabled for the user. (Use expensifail account)
  • Setup NetSuite in OldDot
  1. Open the app with the pre-setup workspace
  2. Go to Accounting
  3. Tap on the Advanced button
  4. Tap on Reimbursable expense option (Enable Custom form ID to access this field)
  5. Tap inside the input field and type something
  6. Tap on Confirm
  7. Do step 5 and 6 for Non-reimbursable expense option as well

Expected Result:

Confirm button saves the input value regardless of the keyboard open state

Actual Result:

Confirm button doesn't work while the soft keyboard is in open state

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538085_1720627955595.Screen_Recording_20240710_190649_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01223454e1811195b9
  • Upwork Job ID: 1811119420448681401
  • Last Price Increase: 2024-07-10
  • Automatic offers:
    • hoangzinh | Reviewer | 103068524
    • shubham1206agra | Reviewer | 103068526
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 10, 2024
  2. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 10, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jul 10, 2024

    @lanitochka17
    Author

    @luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. luacmartins commented on Jul 10, 2024

    @luacmartins
    Contributor

    Seems to come from #44921

  6. luacmartins commented on Jul 10, 2024

    @luacmartins
    Contributor

    I don't think this needs to be a blocker since the button still works, just not when the virtual keyboard is active. Tagging the author and reviewers of the original PR to investigate this issue @shubham1206agra @mananjadhav @yuwenmemon

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 10, 2024
  8. 32 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 2, 2024
  10. changed the title [-][$250] Android - Accounting-Confirm button doesn't work while keyboard is up[/-] [+][HOLD for payment 2024-08-09] [$250] Android - Accounting-Confirm button doesn't work while keyboard is up[/+] on Aug 2, 2024
  11. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

    For reference, here are some details about the assignees on this issue:

  13. shubham1206agra commented on Aug 7, 2024

    @shubham1206agra
    Contributor

    No payment required here.

  14. melvin-bot commented on Aug 9, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @dylanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions