Repository navigation
Accounting - Non-reimbursable expense becomes empty after going offline and online #45191
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #44921
Action Performed:
Pre-requisite
- Collect workspace with accounting enabled.
- NetSuite beta enabled for the user. (Use expensifail account)
- Setup NetSuite in OldDot.
- Open the app with the pre-setup workspace.
- Go to Accounting
- Click on the Advanced button.
- Click on Non-reimbursable expense option (Enable Custom form ID to access this field)
- Input any number and confirm
- Wait a few seconds and go offline
- Go back online again
Expected Result:
The value in Non-reimbursable expense persists
Actual Result:
The value in Non-reimbursable expense becomes empty
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jul 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jul 10, 2024
@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Gonals commentedon Jul 10, 2024
Hmm. This looks like a backend issue, at first glance. Can it be reproduced consistently?
melvin-bot commentedon Jul 10, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Gonals commentedon Jul 10, 2024
Ok, that field is not working at all. It is not a blocker, as this is new functionality and doesn't break any existing stuff, but we need to fix it. I'll look more into it today/tomorrow
Gonals commentedon Jul 10, 2024
Yeeep. This is a typo in the backend. Fix incoming
Christinadobrzyn commentedon Jul 11, 2024
I assume we can move this from hourly to daily now that a PR is in the works. @Gonals does that sound okay?
Gonals commentedon Jul 11, 2024
Yep!
Christinadobrzyn commentedon Jul 15, 2024
Update for Melvin- working on PR https://github.com/Expensify/Web-Expensify/pull/42707
Christinadobrzyn commentedon Jul 16, 2024
I think I'm going to move this to weekly since we're working on PR - https://github.com/Expensify/Web-Expensify/pull/42707
Christinadobrzyn commentedon Jul 23, 2024
PR is in production - https://github.com/Expensify/Web-Expensify/pull/42707 as of the 16th. Can we close this out @Gonals and @lakchote?
Christinadobrzyn commentedon Jul 30, 2024
I'm going to close this out. We can reopen if needed.