Skip to content

[HOLD for payment 2024-10-10] LHN option and badge #45181

Closed

Description

@madmax330

Activity

  1. self-assigned this
    on Jul 10, 2024
  2. VickyStash commented on Jul 22, 2024

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  3. VickyStash commented on Jul 25, 2024

    @VickyStash
    Contributor

    Note: Later phase of implementation

  4. madmax330 commented on Sep 2, 2024

    @madmax330
    ContributorAuthor

    This is waiting on some backend and front-end before it can be started

  5. rezkiy37 commented on Sep 26, 2024

    @rezkiy37
    Contributor

    Hi, I am Michael (Mykhailo) from Callstack, an expert agency and I can work on this issue.

  6. 7 remaining items

  7. melvin-bot commented on Oct 10, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  8. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 14, 2024
  9. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  10. madmax330 commented on Oct 14, 2024

    @madmax330
    ContributorAuthor

    @dylanexpensify can you just make the payment for @getusha for the PR Review here?

  11. dylanexpensify commented on Oct 14, 2024

    @dylanexpensify
    Contributor

    On it!

    Payment summary:

    Contributor+: @getusha $250

    Please apply/request!

  12. getusha commented on Oct 28, 2024

    @getusha
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@getusha] The PR that introduced the bug has been identified. Link to the PR: N/a this was a new feature
    [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a this was a new feature
    [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    [@getusha] Determine if we should create a regression test for this bug. Yes
    [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Go to settings > Workspaces > Select a workspace
    2. Navigate to More features > More features
    3. Enable the Invoices feature.
    4. Verify that the newly added "Invoices" button with the badge has appeared.

    Do we agree 👍 or 👎

  13. garrettmknight commented on Oct 29, 2024

    @garrettmknight
    Contributor

    $250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions