[$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses

@mollfpr

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.5-4
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

User has submitted a few expenses to another user.

Go to staging.new.expensify.com
Go to Search.
Go to Shared.
Click on the select all checkbox of the group expenses (not the select all checkbox for all types of expenses, it's the checkbox for the grouped expenses).
Click on the select all checkbox again to unselect.
Move the cursor outside the grouped expenses.
Note the color of the entire row of grouped expenses (it is still slightly grayed out).
Click on any empty area.
Note that the grouped expenses row is now not grayed out at all.

Expected Result:

In Step 7, after unselecting the grouped expenses, the row will not be grayed out.

Actual Result:

In Step 7, after unselecting the grouped expenses, the row is slightly grayed out.
The grayness is gone after clicking on the empty area (Step 9).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6536029_1720454461384.Screen_Recording_2024-07-08_at_23.34.51.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bcd214466a9b97d7
Upwork Job ID: 1810721978277539440
Last Price Increase: 2024-07-16
Automatic offers:

dominictb | Contributor | 103160053

Issue Owner

Current Issue Owner: @mollfpr

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@stitesExpensify

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@stitesExpensify

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

Grouped expenses row is still slightly grayed out after unselecting the expenses

What is the root cause of that problem?

App/src/components/Pressable/PressableWithFeedback.tsx

Lines 51 to 56 in 6e5a966

    
           <OpacityView 
        
               shouldDim={!!(!rest.disabled && (isPressed || isHovered))} 
        
               dimmingValue={isPressed ? pressDimmingValue : hoverDimmingValue} 
        
               style={wrapperStyle} 
        
               needsOffscreenAlphaCompositing={needsOffscreenAlphaCompositing} 
        
           >

On PressableWithFeedback we set the dimmingValue with the pressDimValue if pressed, the default pressDimValue is 0.8, so it set the opacity to 0.8

And we don't set pressDimmingValue here

What changes do you think we should make in order to solve the problem?

set pressDimmingValue={1} here so it wont greyed out after click

What alternative solutions did you explore? (Optional)

@dominictb

Sorry for the delay 🙏

The proposal from @dominictb looks good to me!

🎀 👀 🎀 C+ reviewed!

@stitesExpensify

Current assignee @stitesExpensify is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@dominictb

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Issue not reproducible during KI retests. (First week)

@sonialiap

@sonialiap I think the automation is not working here, the PR already hit production on the 25th of July. Could you give me the payment summary? Thank you!

@mollfpr

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. It's a pretty rare case and hard to notice.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to NewDot
Go to Search.
Go to Shared.
Click on the select all checkbox of the group expenses (not the select all checkbox for all types of expenses, it's the checkbox for the grouped expenses).
Click on the select all checkbox again to unselect.
Move the cursor outside the grouped expenses.
Verify that the row will not be grayed out.
👍 or 👎

@mollfpr

Payment summary:

@mollfpr $250 - please request in ND
@dominictb $250 - paid in upwork

@mollfpr

$250 approved for @mollfpr

Navigation Menu

Repository navigation

[$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses #45078

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

20 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<OpacityView
	shouldDim={!!(!rest.disabled && (isPressed \|\| isHovered))}
	dimmingValue={isPressed ? pressDimmingValue : hoverDimmingValue}
	style={wrapperStyle}
	needsOffscreenAlphaCompositing={needsOffscreenAlphaCompositing}
	>

[$250] Web -Search - Grouped expenses row is still slightly grayed out after unselecting the expenses #45078

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 9, 2024

melvin-bot commented on Jul 9, 2024

github-actions commented on Jul 9, 2024

m-natarajan commented on Jul 9, 2024

m-natarajan commented on Jul 9, 2024

nyomanjyotisa commented on Jul 9, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

20 remaining items

mollfpr commented on Jul 17, 2024

melvin-bot commented on Jul 17, 2024

melvin-bot commented on Jul 17, 2024

mvtglobally commented on Jul 19, 2024

mollfpr commented on Aug 7, 2024

mollfpr commented on Aug 7, 2024

sonialiap commented on Aug 13, 2024

JmillsExpensify commented on Aug 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions