Skip to content

Track - App shows old receipt when submitting expense with receipt and changing receipt #45062

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4703969
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM
  3. Go to + > Track expense > Manual
  4. Track a manual expense with receipt
  5. Click Submit to someone from the actionable whisper
  6. Select a user and proceed to confirmation page
  7. On confirmation page, click 3-dot menu > Add receipt
  8. Upload a different receipt and submit to the person
  9. Click on the transaction thread

Expected Result:

The receipt view will show the latest uploaded receipt

Actual Result:

The receipt view shows the original uploaded receipt (Step 4) instead of the latest one (Step 8)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536738_1720521133434.bandicam_2024-07-09_18-26-11-551.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 9, 2024
  2. melvin-bot commented on Jul 9, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jul 9, 2024

    @lanitochka17
    Author

    @rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jul 9, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  6. rlinoz commented on Jul 9, 2024

    @rlinoz
    Contributor

    Can't repro in v9.0.5-7, closing

    Screen.Recording.2024-07-09.at.09.57.31.mov
  7. lanitochka17 commented on Jul 9, 2024

    @lanitochka17
    Author

    Hello @rlinoz This issue is still reproducible again.

    You should do a manual expense with receipt, not scan request

    Updated steps:

    1. Go to staging.new.expensify.com
    2. Go to self DM
    3. Go to + > Track expense > Manual
    4. Track a manual expense with receipt
    5. Click Submit to someone from the actionable whisper
    6. Select a user and proceed to confirmation page
    7. On confirmation page, click 3-dot menu > Add receipt
    8. Upload a different receipt and submit to the person
    9. Click on the transaction thread

    Thank you

  8. rlinoz commented on Jul 9, 2024

    @rlinoz
    Contributor

    Oh this happens because ConvertTrackedExpenseToRequest doesn't accept a receipt, we will just use the one we already have attached to that expense. Let me check if we should change the BE or remove the three dot in this flow.

  9. rlinoz commented on Jul 9, 2024

    @rlinoz
    Contributor

    We added the threedots here #44670

  10. reopened this on Jul 9, 2024
  11. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions