Repository navigation
[$250] Bank account - "Hmm... it's not here" page appears after selecting Incorporation state #45060
Description
Activity
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deploymentDailyKSv2KSv2BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Jul 9, 2024 Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this issue might be related to the #collect project.
- removedDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Jul 9, 2024 10 remaining items
2 makes sense to me as well but happy to hear what @s77rt says.
Alternately - do we want to get @nkdengineer / @hoangzinh on this since it seems like a regression from #44981 ?
@dominictb Your RCA is correct. However regarding the solution I would prefer to revert #44981 being a workaround, the
backToparam shouldn't be manipulated. Then we need to find another solution for #44957. The RCA for that issue is not totally clear.If we look at the param in the URL path when selecting state, we'll see that &country=AQ (old country code) is there
Why do we even have that param in the backTo param if the original page didn't have it?
Screen.Recording.2024-07-09.at.7.34.39.PM.mov
cc @nkdengineer
cc @mateuuszzzzz seems like the issue is not completely fixed
@s77rt This is last of 2 blockers, I think the issue that @nkdengineer PR fixed was less severe, user could still add the correct country and state afterwards I assume.
So maybe we can demote that one and revert the CPed change to fix this issue. To unblock a deploy
@mountiny I agree. Let's revert the PR
- addedReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2and removedHourlyKSv2KSv2
on Jul 9, 2024 Ok I have raised the revert PR here #45121 and going to demote the other issue
Reacted by Vinh Hoang- removedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment
on Jul 9, 2024 The PR will be QAed in staging
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4703397
Email or phone of affected tester (no customers): applausetester+vd_ios070824@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Pre-requisite: the user must have created a Workspace and have enabled Workflows.
Expected Result:
Once the user taps on an option, the selected option should be displayed on the Incorporation state field and the user should be able to continue with the add bank account process.
Actual Result:
Once the user taps on an option, "Hmm... it's not here" page is displayed and the user is not able to continue with the add bank account process.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6536449_1720481576566.Ooji8370_1_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @s77rt