Skip to content

[$250] Bank account - "Hmm... it's not here" page appears after selecting Incorporation state #45060

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.5-5
Reproducible in staging?: Y
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4703397
Email or phone of affected tester (no customers): applausetester+vd_ios070824@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: the user must have created a Workspace and have enabled Workflows.

  1. Go to Settings > Workspaces > Workspace > Workflows.
  2. Tap on "Connect bank account".
  3. Select "Connect manually".
  4. Go trough the add bank account process using the testing credentials.
  5. Once you reach the Incorporation state page on the Company info section, tap on the field and try to select a state.

Expected Result:

Once the user taps on an option, the selected option should be displayed on the Incorporation state field and the user should be able to continue with the add bank account process.

Actual Result:

Once the user taps on an option, "Hmm... it's not here" page is displayed and the user is not able to continue with the add bank account process.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6536449_1720481576566.Ooji8370_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018f7892dcd73eb461
  • Upwork Job ID: 1810720111946419022
  • Last Price Increase: 2024-07-09
Issue OwnerCurrent Issue Owner: @s77rt

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 9, 2024
  2. melvin-bot commented on Jul 9, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 9, 2024

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 9, 2024

    @izarutskaya
    Author

    @puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jul 9, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. 10 remaining items

  8. Julesssss commented on Jul 9, 2024

    @Julesssss
    Contributor

    Hi @s77rt can you please review the proposal above, ideally using solution 2?

    We need the solution to resolve two bugs, so the changes will need to pass the test cases listed below:

  9. dangrous commented on Jul 9, 2024

    @dangrous
    Contributor

    2 makes sense to me as well but happy to hear what @s77rt says.

    Alternately - do we want to get @nkdengineer / @hoangzinh on this since it seems like a regression from #44981 ?

  10. s77rt commented on Jul 9, 2024

    @s77rt
    Member

    @dominictb Your RCA is correct. However regarding the solution I would prefer to revert #44981 being a workaround, the backTo param shouldn't be manipulated. Then we need to find another solution for #44957. The RCA for that issue is not totally clear.

    If we look at the param in the URL path when selecting state, we'll see that &country=AQ (old country code) is there

    Why do we even have that param in the backTo param if the original page didn't have it?

    Screen.Recording.2024-07-09.at.7.34.39.PM.mov

    cc @nkdengineer

  11. mountiny commented on Jul 9, 2024

    @mountiny
    Contributor

    cc @mateuuszzzzz seems like the issue is not completely fixed

  12. mountiny commented on Jul 9, 2024

    @mountiny
    Contributor

    @s77rt This is last of 2 blockers, I think the issue that @nkdengineer PR fixed was less severe, user could still add the correct country and state afterwards I assume.

    So maybe we can demote that one and revert the CPed change to fix this issue. To unblock a deploy

  13. s77rt commented on Jul 9, 2024

    @s77rt
    Member

    @mountiny I agree. Let's revert the PR

  14. mountiny commented on Jul 9, 2024

    @mountiny
    Contributor

    Ok I have raised the revert PR here #45121 and going to demote the other issue

  15. mountiny commented on Jul 9, 2024

    @mountiny
    Contributor

    The PR will be QAed in staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions