[HOLD for payment 2024-08-07] [Search v2.1] [App] Create advanced filters

@adamgrzybowski

Implement this section of the design doc.

Holding on:

[HOLD for payment 2024-07-24] [Search v2] [App] Create getFilters #45025

Issue Owner

Current Issue Owner: @sonialiap

@MitchExpensify

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Maybe for this one we can break it down into multiple PRs, maybe adding a couple of filters at a time

yeah sounds good 👍

Let me take care of this task, and I will start with small initial PR, after that if I see possibility of some parallel work, then we will divide this between me and Wojtek if that would make sense. Will be doing smaller PRs with batches of filters like you suggested.

However I have a question: where do I get the values of some filters from? In, Currency, Merchant - are they somewhere inside Onyx easy to be used?

What about:

Tax
report ID
Category
Tag

And in general: should these filters values mostly be generated inside App using existing data, or come from backend?

Reviewing label has been removed, please complete the "BugZero Checklist".

@Kicu

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[Search v2] Add displaying advanced filter values and type/status #46022

If no regressions arise, payment will be issued on 2024-08-07. 🎊

For reference, here are some details about the assignees on this issue:

@Kicu does not require payment (Contractor)
@rayane-djouah requires payment (Needs manual offer from BZ)

@rayane-djouah

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@rayane-djouah

Payment summary:

@rayane-djouah $250 - offer sent in Upwork - paid ✔️

Offer accepted, thanks!

No need for regression test steps for now; they will be added as part of the project.

@Kicu

Payment Summary

Upwork Job

Contributor: @Kicu is from an agency-contributor and not due payment
ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sonialiap)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Paid ✔️

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-07] [Search v2.1] [App] Create advanced filters #45026

42 remaining items

Payment Summary

BugZero Checklist (@sonialiap)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-08-07] [Search v2.1] [App] Create advanced filters #45026

Description

Activity

melvin-bot commented on Jul 8, 2024

luacmartins commented on Jul 9, 2024

Kicu commented on Jul 10, 2024

42 remaining items

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

melvin-bot commented on Jul 31, 2024

sonialiap commented on Aug 2, 2024

rayane-d commented on Aug 2, 2024

rayane-d commented on Aug 4, 2024

melvin-bot commented on Aug 7, 2024

Payment Summary

BugZero Checklist (@sonialiap)

sonialiap commented on Aug 8, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions