Skip to content

[Search v1] - Action field remains as "Paid" after expenses are unapproved until page is revisited #45001

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.5-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat as admin
  3. Submit two expenses
  4. Go to Search > Shared
  5. Click on the grouped expenses
  6. Pay elsewhere the expense
  7. Go back to Search > Shared
  8. Click on the grouped expenses
  9. Click on the report header
  10. Click Unapprove

Expected Result:

The action field for the grouped expenses will turn to "Action"

Actual Result:

The action field for the grouped expenses remains "Paid", until the Search page is revisited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6536222_1720466433439.20240709_031521.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  2. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Jul 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Jul 8, 2024

    @lanitochka17
    Author

    @tylerkaraszewski FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. lanitochka17 commented on Jul 8, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-collect - Release 1

  6. mountiny commented on Jul 8, 2024

    @mountiny
    Contributor
  7. luacmartins commented on Jul 8, 2024

    @luacmartins
    Contributor

    hmm this is a tricky one. We save the action in its own key in snapshot_ so the live updates don't change this key since the live onyx data, e.g. report_ and transactions_ don't have the action key.

  8. luacmartins commented on Jul 8, 2024

    @luacmartins
    Contributor

    This is not a blocker though since I was able to reproduce in production.

  9. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  10. 14 remaining items

  11. moved this from HOT PICKS to Polish in [#whatsnext] #wave-collecton Jul 23, 2024
  12. moved this from Polish to HOT PICKS in [#whatsnext] #wave-collecton Jul 23, 2024
  13. removed their assignment
    on Jul 23, 2024
  14. melvin-bot commented on Jul 29, 2024

    @melvin-bot

    Eep! 4 days overdue now. Issues have feelings too...

  15. melvin-bot commented on Jul 31, 2024

    @melvin-bot

    Still overdue 6 days?! Let's take care of this!

  16. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  17. tylerkaraszewski commented on Aug 2, 2024

    @tylerkaraszewski
    Contributor

    @luacmartins What do you think should we just close this then?

  18. luacmartins commented on Aug 6, 2024

    @luacmartins
    Contributor

    Yea, I think we can close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DailyKSv2EngineeringHot PickReady for an engineer to pick up and run withInternalRequires API changes or must be handled by Expensify staff

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions