Skip to content

[$250] IOU - Multiple IOUs are unapproved when a single IOU is unapproved #44969

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): natnael.expensify+0a89fdndafadf@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition: Create workspace > More features > Enable workflow > Enable Add approvals > Make yourself approver

  1. Navigate to a workspace chat
  2. Submit 2 manual requests with different amounts
  3. Click on the IOU preview component
  4. Click Approve button
  5. Click on the IOUs
  6. Click header
  7. Click unapprove
  8. Navigate back to expense report

Expected Result:

Only the unapproved report should be unapproved

Actual Result:

Both IOUs are unapproved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6535812_1720442435170.Screen_Recording_2024-07-08_at_3.29.15_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0166593468459204f3
  • Upwork Job ID: 1810443215436393315
  • Last Price Increase: 2024-07-08
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  2. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 8, 2024

    @izarutskaya
    Author

    @lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jul 8, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Jul 8, 2024

    @izarutskaya
    Author

    Production
    image

  8. 31 remaining items

  9. Beamanator commented on Jul 18, 2024

    @Beamanator
    Contributor

    PR was #45049! But it fixed multiple issues FYI 🙏

  10. lschurr commented on Jul 22, 2024

    @lschurr
    Contributor

    Ok, so payment is being issued elsewhere? Or do we need to pay here @Beamanator?

  11. melvin-bot commented on Jul 22, 2024

    @melvin-bot

    @Beamanator @suneox @lschurr @stitesExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  12. garrettmknight commented on Jul 23, 2024

    @garrettmknight
    Contributor

    @lschurr I think it's just payment for @bernhardoj here via this comment.

  13. lschurr commented on Jul 23, 2024

    @lschurr
    Contributor

    Great, thanks!

    Payment summary:

    • Contributor: @bernhardoj $250 (please request in NewDot)
  14. bernhardoj commented on Jul 24, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  15. JmillsExpensify commented on Jul 24, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions