Repository navigation
Workspace - The price $9 in upgrade page is not legible in light mode #44965
Description
Activity
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@Gonals FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 2
Proposal
Please re-state the problem that we are trying to solve in this issue.
The price $9 in upgrade page is not legible in light mode
What is the root cause of that problem?
We are passing
styles.textWhiteinstead ofstyles.themeTextColorhereWhat changes do you think we should make in order to solve the problem?
Change
styles.textWhitetostyles.themeTextColorbelow
What alternative solutions did you explore? (Optional)
Proposal
Please re-state the problem that we are trying to solve in this issue.
Workspace - The price $9 in upgrade page is not legible in light mode.
What is the root cause of that problem?
Text colour is fixed to white in the below line, which makes it not legible in light mode.
What changes do you think we should make in order to solve the problem?
styles.textWhiteneeds to be removed.<Text style={[styles.textNormal, styles.textSupporting]}> {translate(`workspace.upgrade.${feature.id}.pricing.onlyAvailableOnPlan`)} <Text style={[styles.textBold]}>{translate(`workspace.upgrade.${feature.id}.pricing.amount`)}</Text> {translate(`workspace.upgrade.${feature.id}.pricing.perActiveMember`)} </Text>I realise this shouldn't be a blocker as the feature is locked, but I had already started...
PR in review
Merged, no need to CP
@Julesssss Should this be closed?
Reacted by Jules
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #43822
Action Performed:
Precondition:
)
Expected Result:
The content will be legible in light mode
Actual Result:
The price $9 is not legible in light mode
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub