Repository navigation
IOU - Details modal is dismissed after editing title #44963
Description
Activity
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this issue might be related to the #collect project.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Details modal is dismissed after editing title
What is the root cause of that problem?
We are dismissing the modal and navigating to the previous report here
App/src/pages/EditReportFieldPage.tsx
Line 84 in 51dd814
What changes do you think we should make in order to solve the problem?
We should change
Navigation.dismissModal(report?.reportID)withNavigation.goBack()What alternative solutions did you explore? (Optional)
20 remaining items
done @jayeshmangwani !
Reacted by Jayesh Mangwani@adelekennedy the pr was deployed to production 8 days ago.
Thank you @etCoderDysto - the automatic update failed here.
Reacted by Night CoderYes, mevlin is not adding lables.
@jayeshmangwani BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- The PR that introduced the bug has been identified. Link to the PR:
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
Payouts due:
- Contributor: $250 @etCoderDysto (Upwork)
- Contributor+: $250 @jayeshmangwani (NewDot)
@etCoderDysto will you link your upwork profile here?
- [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: [Details Revamp] Allow Editing Report Title from Details Page #44671
- [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Details Revamp] Allow Editing Report Title from Details Page #44671 (comment)
- [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
- [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
- [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
- Go to a workspace chat.
- Submit a manual expense.
- Click on the IOU preview component.
- Click on the report header -> Title.
- Edit the title and click Save.
- Verify that you are navigated back to the Details page.
Do we agree 👍 or 👎
Reacted by adelekennedyoffer sent @etCoderDysto
offer sent @etCoderDysto
I have accepted the offer. Thank you!
Reacted by adelekennedyRequested $250
$250 approved for @jayeshmangwani
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: New feature
Email or phone of affected tester (no customers): natnael.expensify+0a89fdndafadf@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Expected Result:
User should be returned to Details RHP
Actual Result:
Details RHP modal is dismissed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6535803_1720442342286.Screen_Recording_2024-07-08_at_3.14.10_in_the_afternoon.mp4
View all open jobs on GitHub