Skip to content

IOU - Title change is not reflected in header and details section #44962

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: New feature
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Navigate to p2p chat
  2. Submit a manual expense
  3. Click on the IOU preview component
  4. Click on report header > Title
  5. Edit title & click Save

Expected Result:

Change in title should be reflected in report header and details section

Actual Result:

Change in title is not reflected in report header and details section

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6535804_1720442344045.Screen_Recording_2024-07-08_at_3.03.24_in_the_afternoon.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 8, 2024
  2. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jul 8, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jul 8, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jul 8, 2024

    @izarutskaya
    Author

    @anmurali I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jul 8, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. ishpaul777 commented on Jul 8, 2024

    @ishpaul777
    Contributor

    I think Title field should not editable in P2P chat. i'll raise a quick PR to resolve this since this comes from a PR i reviewed, once we confirm

    cc @trjExpensify

  8. ishpaul777 commented on Jul 8, 2024

    @ishpaul777
    Contributor

    Above is a draft PR i'll open once confirmed above ^

  9. trjExpensify commented on Jul 8, 2024

    @trjExpensify
    Contributor

    I think Title field should not editable in P2P chat. i'll raise a quick PR to resolve this since this comes from a PR i reviewed, once we confirm

    Right, report titles are a feature on workspaces whereas iouReports are not on workspaces.

  10. danieldoglas commented on Jul 9, 2024

    @danieldoglas
    Contributor

    removing backend blocker on this issue.

  11. ishpaul777 commented on Jul 9, 2024

    @ishpaul777
    Contributor

    i have opened PR for review #44978

  12. Julesssss commented on Jul 9, 2024

    @Julesssss
    Contributor

    We'll continue with the PR as it does resolve the issue. But as far as I can tell, edit is a new feature and should not be blocking deploy:

    Prod:
    Screenshot 2024-07-09 at 13 56 01

    Staging:
    Screenshot 2024-07-09 at 13 57 39

  13. Julesssss commented on Jul 9, 2024

    @Julesssss
    Contributor

    Ah, this appears to have been resolved by a different deploy blocker fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions