[HOLD for payment 2024-07-17][$250] Expense - App crashes when opening an expense report after submitting another expense

@allroundexperts

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.5-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Sign in to an account
Go to FAB > submit expense > Manual expense
Enter an amount
Select a user you have never submitted an expense to
Submit the expense
Navigate to the chat with the user you just submitted the expense to
Click on the "+" icon
Click on submit expense > Manual expense > Enter amount >Next > Submit
Go to the combined expense report and open the first expense you submitted

Expected Result:

The expense report opens and the app does not crash

Actual Result:

App crashes after opening the report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6535811_1720442411664.2024-07-08_15_15_43.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ab200eebc7b06724
Upwork Job ID: 1810395750787214444
Last Price Increase: 2024-07-08
Automatic offers:

brunovjk | Reviewer | 103047644
nkdengineer | Contributor | 103047648

Issue Owner

Current Issue Owner: @allroundexperts

@rlinoz

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@rlinoz

@rlinoz FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Crash seems to be related to Policy key changing? Are we temporarily setting it to FAKE

Taking a look at this, weird one

It looks like we are creating the first money request in a different policyID other than _FAKE_, and when we open that report again we set it back to fake, which then crashes. Looking like a backend bug.

not happening in prod though, and apparently we didn't deploy anything related to staging in Web-E

Hmm, nice. At least it points back to app.

I wonder if any of the PRs seem associated with policies. Does this issue seem related?

Oops lol, ignore that 🤦

Yeah, tested with the production Web-E branch and still happens in dev, so I am gonna go ahead and remove the DeployBlocker for Web-E, will continue looking after lunch.

@brunovjk

Thx @brunovjk , that's weird that the fee isn't removed too, hmmm...
How has the 10% fee been debited if it takes them 5 days to pay? Do you have any screenshots you can share.

Currently, all contributors need to be paid via Upwork for 18 months from their first hire, unfortunately you have a while. 2025-08-09 Bruno Rocha

@brunovjk

Thx @brunovjk , that's weird that the fee isn't removed too, hmmm... How has the 10% fee been debited if it takes them 5 days to pay? Do you have any screenshots you can share.

It shows that the fee was removed, I tried refund anyway, can you confirm if everything went well?

Currently, all contributors need to be paid via Upwork for 18 months from their first hire, unfortunately you have a while. 2025-08-09 Bruno Rocha

Thank you very much @mallenexpensify for the information!!!! I'll leave a note here, it goes quickly :D

@brunovjk

Yup, confirming we got the refund. Thanks @brunovjk , I know it's a bit of a pain. Luckily it happens pretty rarely.

Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @allroundexperts owed $250 via NewDot.

@isabelastisser when you pay contributors can you provide more detail in the description so that we know who's getting paid where, and how much? Thx.

@allroundexperts plz complete the BZ checklist below, seems like we'd want a regression test for this, right?

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@] The PR that introduced the bug has been identified. Link to the PR:
[@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@] Determine if we should create a regression test for this bug.
[@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[ ]

@rlinoz

@rlinoz, @allroundexperts, @isabelastisser, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@allroundexperts

friendly bump @allroundexperts

Checklist

I was not able to pinpoint the exact PR which caused this issue.
N/A
N/A
A regression test would be useful here.

Regression test

Sign in to an account and go to FAB > submit expense > Manual expense
Enter an amount and select a user you have never submitted an expense to
Submit the expense
Navigate to the chat with the user you just submitted the expense to
Click on the "+" icon
Click on submit expense > Manual expense > Enter amount >Next > Submit
Go to the combined expense report and open the first expense you submitted

Verify that the expense report opens and the app does not crash

Do we 👍 or 👎 ?

@mallenexpensify

Sorry for the confusion, team! And thanks for handling this, @mallenexpensify!

@rlinoz, can you please review the regression test above? Thanks!

I think since this was caught during regression testing we can skip creating a new one.

@rlinoz

Sounds good, thanks @rlinoz!

This is all set, closing!

@allroundexperts

$250 approved for @allroundexperts

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17][$250] Expense - App crashes when opening an expense report after submitting another expense #44960

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

40 remaining items

Checklist

Regression test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-17][$250] Expense - App crashes when opening an expense report after submitting another expense #44960

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 8, 2024

github-actions commented on Jul 8, 2024

lanitochka17 commented on Jul 8, 2024

Julesssss commented on Jul 8, 2024

rlinoz commented on Jul 8, 2024

rlinoz commented on Jul 8, 2024

rlinoz commented on Jul 8, 2024

Julesssss commented on Jul 8, 2024

Julesssss commented on Jul 8, 2024

rlinoz commented on Jul 8, 2024

40 remaining items

mallenexpensify commented on Jul 20, 2024

brunovjk commented on Jul 20, 2024

mallenexpensify commented on Jul 22, 2024

melvin-bot commented on Jul 23, 2024

rlinoz commented on Jul 24, 2024

allroundexperts commented on Jul 29, 2024

Checklist

Regression test

isabelastisser commented on Jul 29, 2024

rlinoz commented on Jul 29, 2024

isabelastisser commented on Jul 29, 2024

JmillsExpensify commented on Aug 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions