Skip to content

[Payment card / Subscription] There is no Retry payment button but payment failed #44917

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.4-6
Reproducible in staging?: Y
Reproducible in production?: N
Found when executing PR : #44268
Email or phone of affected tester (no customers): irvgut7@gmail.com and irvgut7+050724@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

NewDot

  1. Go directly to subscription page - https://staging.new.expensify.com/settings/subscription
  2. Add a payment card if you don't have it
  3. Click to Subscriptions (we should go to OldDot)

OldDot:

  1. Subscribe to Expensify.org on Workspaces page
  2. Go to Settings>Account>Payments
  3. Scroll down (you should see that payment failing)

7 Go back to NewDot and click Retry payment

Expected Result:

The user should see the Retry payment button.

Actual Result:

When user returns to NewDot, he does not see Retry payment button but payment failed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Recording.2598.mp4
Recording.2594.mp4

IMG_4028

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 5, 2024
  2. melvin-bot commented on Jul 5, 2024

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 5, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 5, 2024
  6. 10 remaining items

  7. blimpich commented on Jul 5, 2024

    @blimpich
    Contributor

    This is probably an internal issue. Going to label this as an internal hot pick for now.

    It's possible that this is a frontend issue, haven't investigated enough to say for 100% sure.

  8. added
    InternalRequires API changes or must be handled by Expensify staff
    Hot PickReady for an engineer to pick up and run with
    on Jul 5, 2024
  9. moved this from Polish to HOT PICKS in [#whatsnext] #wave-collecton Jul 5, 2024
  10. trjExpensify commented on Jul 8, 2024

    @trjExpensify
    Contributor

    Looking at the steps:

    OldDot:
    Subscribe to Expensify.org on Workspaces page
    Go to Settings>Account>Payments
    Scroll down (you should see that payment failing)

    ... adding personal/corporate karma donations were out of scope of the project, so I wonder if we aren't getting updates for this failed billing scenario specifically or if it's paying your "normal" Expensify subscription. So it would be good to:

    1. Test if Retry payment is missing for a subscription to Expensify NOT corporate/personal karma
    2. If not, it's just related to corporate/personal karma donations, make that clearer in the issue.

    CC: @MitchExpensify

  11. MitchExpensify commented on Jul 8, 2024

    @MitchExpensify
    Contributor
    1. I don't think we need to have a "Retry billing" banner for failed corporate karma payments in NewDot.
    2. The failed July 5th payment looks to be on an individual subscription which could be a factor
    image image

    I don't think we need to show individual subscription failed payment actions in NewDot do we?

  12. izarutskaya commented on Jul 8, 2024

    @izarutskaya
    Author

    Both testing accounts are the owners of workspaces. Please check my videos. Thanks

    Recording.2603.mp4
    Recording.2601.mp4
  13. MitchExpensify commented on Jul 8, 2024

    @MitchExpensify
    Contributor

    Got it, the $4.99 charge is for an individual subscription so I don't think there is a bug here as nothing I can see related to a group workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringHot PickReady for an engineer to pick up and run withInternalRequires API changes or must be handled by Expensify staff

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions