Repository navigation
[HOLD for payment 2024-07-25] [$250] [Payment card / Subscription] When adding Payment card, there is a slight delay before it shows #44904
Description
Activity
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@mountiny FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
61 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-25. 🎊
For reference, here are some details about the assignees on this issue:
- @getusha requires payment through NewDot Manual Requests
- @dominictb requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@getusha] The PR that introduced the bug has been identified. Link to the PR:
- [@getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@getusha] Determine if we should create a regression test for this bug.
- [@getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment summary:
@getusha $250 - please request in ND - please complete the checklist
@dominictb $250 - paid ✔️@sonialiap, @blimpich, @getusha, @dominictb Eep! 4 days overdue now. Issues have feelings too...
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- The PR that introduced the bug has been identified. Link to the PR: remove GBP as a currency for the subscription page #44858
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44858/files#r1697402990
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
- Determine if we should create a regression test for this bug. No, seems like a slight improvement / polish
- If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a
Reacted by Sonia Liapounova$250 approved for @getusha
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4-6
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #44361
Action Performed:
Expected Result:
User expects that after saving the card data immediately loads and displays
Actual Result:
Several seconds go by before the card actually appears on the Sub page, leading the user to think the details did not save
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6534057_1720183810076.Add_payment_takes_a_while_to_load.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @getusha