[HOLD for payment 2024-07-24] [$250] [Payment card / Subscription] When clicking "Change payment", past data still shows on new form

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Found when executing PR : #44361
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Access staging.new.expensify.com
Sign into a valid account (Beta enabled)
Access https://staging.new.expensify.com/settings/subscription/add-payment-card
Input valid card data
Click on "Change Payment" after the card data has been set

Expected Result:

User expects that if the fields are cleared, then all fields should be cleared.

Actual Result:

The expiration date still shows from the previous card (And is in the correct format, missing a digit) and the Zip code is still showing as well.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6533470_1720126583755.Fields_are_still_displaying.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f36eea0f55c219c3
Upwork Job ID: 1809282474389988839
Last Price Increase: 2024-07-05

Issue Owner

Current Issue Owner: @mallenexpensify

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@madmax330

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@mallenexpensify

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

@Pujan92

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: [Payment card / Subscription] When clicking "Change payment", past data still shows on new form #45334

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

@Pujan92 does not require payment (Contractor)
@fedirjh requires payment through NewDot Manual Requests

@Pujan92

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Pujan92 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@Pujan92 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Pujan92 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Pujan92 / @fedirjh] Determine if we should create a regression test for this bug.
[@Pujan92 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

BugZero Checklist:

Link to the PR: N/A, this is a feature request
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

1. Open App
2. Go to /settings/subscription/add-payment-card
3. Enter valid card details and add it
4. Verify the card data has been successfully added to your account
5. Click on "Change Payment" option 
6. Verify previously added card details doesn't show in the form

Do we agree 👍 or 👎

@Pujan92

@Pujan92 does not require payment (Contractor)

@Pujan92 this should be fixed now to denote you're paid via NewDot. Comment here if you see any assigned issues from today forward where it's not.

@fedirjh , thanks for test case steps

https://github.com/Expensify/Expensify/issues/414485

@Pujan92

Payment Summary

Upwork Job

Reviewer: @Pujan92 owed $250 via NewDot
Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@mallenexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1809282474389988839/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@mallenexpensify

@mallenexpensify can you confirm the checklist above so I can approve payments?

@Pujan92

@Pujan92, @blimpich, @mallenexpensify, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Pujan92

Contributor: @Pujan92 due $250 via NewDot
Contributor+: @fedirjh due $250 via NewDot

Thanks!

@fedirjh

$250 approved for @fedirjh

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-24] [$250] [Payment card / Subscription] When clicking "Change payment", past data still shows on new form #44886

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

40 remaining items

BugZero Checklist:

Payment Summary

BugZero Checklist (@mallenexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-24] [$250] [Payment card / Subscription] When clicking "Change payment", past data still shows on new form #44886

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 5, 2024

melvin-bot commented on Jul 5, 2024

github-actions commented on Jul 5, 2024

izarutskaya commented on Jul 5, 2024

izarutskaya commented on Jul 5, 2024

40 remaining items

melvin-bot commented on Jul 17, 2024

melvin-bot commented on Jul 17, 2024

fedirjh commented on Jul 22, 2024

BugZero Checklist:

mallenexpensify commented on Jul 22, 2024

melvin-bot commented on Jul 24, 2024

Payment Summary

BugZero Checklist (@mallenexpensify)

JmillsExpensify commented on Jul 25, 2024

melvin-bot commented on Jul 26, 2024

mallenexpensify commented on Jul 26, 2024

JmillsExpensify commented on Aug 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions