Repository navigation
[HOLD for payment 2024-07-22] Expensify Card - Blue outline does not wrap the user row properly when navigating via Tab #44871
Description
Activity
Triggered auto assignment to @puneetlath (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
I am demoting this one since it doesn't impact the user and tab navigation is not a mainline flow.
roposal
Please re-state the problem that we are trying to solve in this issue.
Expensify Card - Blue outline does not wrap the user row properly when navigating via Tab
What is the root cause of that problem?
We have incorrectly configured the styles on
WorkspaceCardListRow:
App/src/pages/workspace/expensifyCard/WorkspaceCardListRow.tsx
Lines 41 to 43 in 77d380c
We need to update these, so that blue border is applied correctly.What changes do you think we should make in order to solve the problem?
We should have
styles.selectionListPressableItemWrapperas the wrapping styles on the Pressable hereWe should update the view styles here
<View style={[styles.flexRow, styles.flex1, styles.justifyContentBetween, styles.userSelectNone, styles.alignItemsCenter, style]}>
We should update the
contentContainerStyleasstyles.mb3for theOfflineWithFeedbackhereWe will do other small adjustments to clean up the styles.
Result
Screen.Recording.2024-07-05.at.2.56.00.AM.mov
9 remaining items
We can close this one out @mountiny , the PR was deployed to production, no payment here
- changed the title
[-]Expensify Card - Blue outline does not wrap the user row properly when navigating via Tab[/-][+][HOLD for payment 2024-07-22] Expensify Card - Blue outline does not wrap the user row properly when navigating via Tab[/+]on Jul 15, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
- @narefyev91 does not require payment (Contractor)
- @allgandalf requires payment (Needs manual offer from BZ)
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applaus - Internal Team
Action Performed:
Expected Result:
The blue outline will wrap the user row properly
Actual Result:
The blue outline does not wrap the user row properly
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6533320_1720115230094.20240705_014356.mp4
View all open jobs on GitHub