[WAITING ON DOMINICTB][HOLD for payment 2024-08-01] [$250] Report field - List field shows "dropdown" as selected when different initial value is default

@jliexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4695978
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses.
Go to workspace settings > Report fields.
Click Add field.
Create a List type report field, add a few list values and select an initial value (important).
Go to workspace chat.

Expected Result:

The List type report field will have the initial list value in Step 6 as selected.

Actual Result:

The List type report field shows "dropdown" as the initial list value.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6533100_1720103746001.20240704_223441.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0162c3c8677de552d3
Upwork Job ID: 1808914763702199073
Last Price Increase: 2024-07-04
Automatic offers:

shubham1206agra | Contributor | 102994079

Issue Owner

Current Issue Owner: @jliexpensify

@jliexpensify

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@stitesExpensify

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@stitesExpensify

@stitesExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

The List type report field shows "dropdown" as the initial list value.

What is the root cause of that problem?

we already have the logic to merge the reportField from policy and report in

App/src/libs/ReportUtils.ts

Line 2580 in f73cdc4

    
           const mergedFieldIds = Array.from(new Set([...policyReportFields.map(({fieldID}) => fieldID), ...reportFields.map(({fieldID}) => fieldID)]));

But we're not setting the optimistic data for report.fieldList in

App/src/libs/actions/Policy/ReportFields.ts

Line 154 in f73cdc4

optimisticData: [

so the reportFiled in this case will be the reportField from policy

App/src/components/ReportActionItem/MoneyReportView.tsx

Line 68 in f73cdc4

    
           const fieldValue = isTitleField ? report.reportName : reportField.value ?? reportField.defaultValue;

and it has value: dropdown

What changes do you think we should make in order to solve the problem?

We can get the report by policyID and expense type.

then set the optimistic data for reportField of report same as what BE return (without value key)

We can check the bug for other field type (text, date) as well.

What alternative solutions did you explore? (Optional)

We can remove the value: dropdown in reportField of policy optimistically

Result

@dominictb

bump @dominictb what's your Upworks profile? Could you also add your Upworks name to your GH profile please?

Alternatively, you can apply here: https://www.upwork.com/jobs/~0162c3c8677de552d3

@rushatgabhane

Payment Summary

Upwork Job

Reviewer: @rushatgabhane owed $250 via NewDot
ROLE: @dominictb paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1808914763702199073/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@dominictb

Bump @dominictb to provide me with your upworks profile

Bump @rushatgabhane for checklist

@jliexpensify

@jliexpensify regression steps to add -

Go to workspace settings > Report fields.
Click Add field.
Create a List type report field, add a few list values and select an initial value (important).
Go to workspace chat.
Submit two expenses.
Verify that: The List type report field will have the initial list value as selected

no separate payment required for report fields

@jliexpensify

@jliexpensify Sorry for the delay, here's my Upwork profile https://www.upwork.com/freelancers/~01f70bed1934fd35d5

@dominictb

Thanks @dominictb , invited you.

@jliexpensify

@jliexpensify I accepted it thanks 🙏

Paid, and job closed.

Navigation Menu

Repository navigation

[WAITING ON DOMINICTB][HOLD for payment 2024-08-01] [$250] Report field - List field shows "dropdown" as selected when different initial value is default #44843

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

46 remaining items

Payment Summary

BugZero Checklist (@jliexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[WAITING ON DOMINICTB][HOLD for payment 2024-08-01] [$250] Report field - List field shows "dropdown" as selected when different initial value is default #44843

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 4, 2024

melvin-bot commented on Jul 4, 2024

github-actions commented on Jul 4, 2024

kavimuru commented on Jul 4, 2024

kavimuru commented on Jul 4, 2024

dominictb commented on Jul 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

46 remaining items

jliexpensify commented on Aug 1, 2024

melvin-bot commented on Aug 1, 2024

Payment Summary

BugZero Checklist (@jliexpensify)

jliexpensify commented on Aug 2, 2024

rushatgabhane commented on Aug 2, 2024

rushatgabhane commented on Aug 2, 2024

dominictb commented on Aug 2, 2024

jliexpensify commented on Aug 2, 2024

dominictb commented on Aug 2, 2024

jliexpensify commented on Aug 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions