[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Search - Empty list does not turn to empty state screen until page is revisited

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when validating #44385
Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

User has only unpaid expenses.

Go to staging.new.expensify.com
Go to Search > Shared.
Select all the expenses.
Click on the dropdown > Delete.
Delete the expenses.

Expected Result:

The empty state screen will show up after deleting all the expenses.

Actual Result:

The list is empty with field row after deleting all the expenses.
It only shows empty state screen after revisiting the page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6532525_1720043955916.20240704_055548.mp4

View all open jobs on GitHub

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MariaHCD

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@MariaHCD

@MariaHCD FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Hey, I'm from Software Mansion and I will investigate this issue.

@luacmartins

cc: @luacmartins @WojtekBoman for visibility

@MariaHCD

@MariaHCD @luacmartins I see three people on the PR, two are freelancers. I see fedirjh completed the checklist and neonbhai left a comment. Should they both be paid for the review?

@luacmartins

I believe only fedirjh should be compensated for their C+ review. Will let @luacmartins confirm.

@fedirjh

Correct, we only need to compensate @fedirjh for the review!

@fedirjh

Payment summary:

@fedirjh $250 - please request in ND

@fedirjh

Payment Summary

Upwork Job

Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@sonialiap)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@fedirjh

$250 approved for @fedirjh

@fedirjh

Last step here is the checklist

@fedirjh I believe this falls to you as the C+?

BugZero Checklist:

Link to the PR: [Search v1] Add bulk actions #44385
Link to comment: Author was aware and fixed it
Link to discussion: N/A
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Precondition: User has only unpaid expenses.

1. Go to Search -> Shared.
2. Select all the expenses.
3. Click on the dropdown > Delete.
4. Delete the expenses.
5. Verifythat  empty state screen will show up after deleting all the expenses.

Do we agree 👍 or 👎

Thanks Fedi!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Search - Empty list does not turn to empty state screen until page is revisited #44803

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

28 remaining items

Payment Summary

BugZero Checklist (@sonialiap)

BugZero Checklist:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Search - Empty list does not turn to empty state screen until page is revisited #44803

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 4, 2024

melvin-bot commented on Jul 4, 2024

github-actions commented on Jul 4, 2024

m-natarajan commented on Jul 4, 2024

kosmydel commented on Jul 4, 2024

MariaHCD commented on Jul 4, 2024

28 remaining items

sonialiap commented on Jul 18, 2024

MariaHCD commented on Jul 18, 2024

luacmartins commented on Jul 18, 2024

sonialiap commented on Jul 22, 2024

melvin-bot commented on Jul 22, 2024

Payment Summary

BugZero Checklist (@sonialiap)

JmillsExpensify commented on Jul 22, 2024

sonialiap commented on Jul 24, 2024

fedirjh commented on Jul 24, 2024

BugZero Checklist:

sonialiap commented on Jul 25, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions