Skip to content

Room - LHN is empty after leaving public room anonymously #44800

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.4.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Log out of ND if logged in.
  2. Navigate to a public room link.
  3. Tap on the room header.
  4. Tap Leave.

Expected Result:

LHN will not be blank after leaving public room anonymously.

Actual Result:

LHN is blank after leaving public room anonymously.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6532511_1720042644305.leave_room.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 4, 2024
  2. melvin-bot commented on Jul 4, 2024

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 4, 2024

    @melvin-bot

    Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jul 4, 2024

    @m-natarajan
    Author

    @hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. m-natarajan commented on Jul 4, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #vip-vsb

  7. situchan commented on Jul 4, 2024

    @situchan
    Contributor

    FYI: we're hiding Leave button in #44560

  8. RachCHopkins commented on Jul 4, 2024

    @RachCHopkins
    Contributor

    @hayata-suenaga I'm new to the BugZero team, do you need me to do anything on this?

  9. hayata-suenaga commented on Jul 4, 2024

    @hayata-suenaga
    Contributor

    FYI: we're hiding Leave button in #44560

    Seems like the bug will be fixed when the leave button is hidden in the linked PR. Removing the deploy blocker and and closing this issue as the issue is tracked in this issue.

  10. hayata-suenaga commented on Jul 4, 2024

    @hayata-suenaga
    Contributor

    @RachCHopkins, this issue is about a bug that is categorized as a "deploy blocker". These are bugs that are found in the staging New Expensify but those that don't exist on production. This means that the bug was introduced in the code that was recently written. We have to fix these bugs before we deploy the new code to production.

    Usually, an internal engineer is assigned to these issues and they handle the issue.

    As a bug zero, you can do:

    • tag internal engineer who was assigned to a deploy blocker issue on New Expensify if they haven't commented on the issue for a while
    • If there is some contributor who identify themselves as the one introduced the bug, you can assign them so that they can fix the bug (usually, the assigned internal engineer does this, but if they haven't commented on the issue, you can also do that)

    In this particular issue, the fix has already been worked on, so I decided to close this issue.

  11. removed
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions