Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Report fields - "title" report field shows up and app crashes when clicking on checkbox. #44797
Description
Activity
Triggered auto assignment to @hayata-suenaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsb
Proposal
Please re-state the problem that we are trying to solve in this issue.
title" report field shows up and app crashes when clicking on checkbox.
What is the root cause of that problem?
The
CreateWorkspacecontains one fieldList onyxData
There seems already a filter for it, but it not working properly
App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
Lines 48 to 53 in a84f68e
What changes do you think we should make in order to solve the problem?
Update the filter to filter by
value.fieldIDinstead ofkeyconst filteredPolicyFieldList = useMemo(() => { if (!policy?.fieldList) { return {}; } return Object.fromEntries(Object.entries(policy.fieldList).filter(([_, value]) => value.fieldID !== 'text_title')); }, [policy]);What alternative solutions did you explore? (Optional)
24 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
For reference, here are some details about the assignees on this issue:
- @rushatgabhane requires payment through NewDot Manual Requests
- @waterim does not require payment (Contractor)
- @shubham1206agra requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
- [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
- [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2024-07-17] Report fields - "title" report field shows up and app crashes when clicking on checkbox.[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Report fields - "title" report field shows up and app crashes when clicking on checkbox.[/+]on Jul 15, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
- @rushatgabhane requires payment through NewDot Manual Requests
- @waterim does not require payment (Contractor)
- @shubham1206agra requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@rushatgabhane / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
- [@rushatgabhane / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@rushatgabhane / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@rushatgabhane / @shubham1206agra] Determine if we should create a regression test for this bug.
- [@rushatgabhane / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@rushatgabhane @shubham1206agra can you please complete the checklist?
@slafortune this is a new feature and we are handling all these cases as part of the report fields configuration project so I think we can close this issue now, payments are done per project
Reacted by Stevie LaFortune- moved this from Release 2: Summer 2024 (Aug) to Done in #expensify-bugs
on Jul 19, 2024 - moved this to Done in [wave-control] Report Fields Configuration
on Jul 19, 2024
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.4.0
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
"title" report field will not show up and app will not crash when clicking on the checkbox.
Actual Result:
"Title" report field shows up and app crashes when clicking on the checkbox.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6532499_1720042271423!crash.txt
Bug6532499_1720042271417.crash.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @slafortune