[HOLD for payment 2024-08-01] [$250] Wallet : Incorrect padding on "we're reviewing..." label

@shawnborton

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719470547378329

Action Performed:

Go to staging.new.expensify.com
Go to settings > Wallet
Enable Wallet
Notice the message "we're reviewing your information, please check back in a few minutes!"

Expected Result:

There should be no padding issue or too much indent

Actual Result:

Message has too much indentation and we should remove the horizontal padding

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016598836022b81a73
Upwork Job ID: 1811437561354747333
Last Price Increase: 2024-08-01
Automatic offers:

ShridharGoel | Contributor | 103132371

Issue Owner

Current Issue Owner: @sakluger

@muttmuure

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet : Incorrect padding on "we're reviewing..." label

What is the root cause of that problem?

alertViewStyle has ph5 style, and it is being used below which adds the extra horizontal padding.

App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines 440 to 464 in cd72f1b

    
           if (isPendingOnfidoResult) { 
        
               return ( 
        
                   <View style={alertViewStyle}> 
        
                       <Icon 
        
                           src={Expensicons.Hourglass} 
        
                           fill={theme.icon} 
        
                       /> 
        
                       <Text style={alertTextStyle}>{translate('walletPage.walletActivationPending')}</Text> 
        
                   </View> 
        
               ); 
        
           } 
        
           if (hasFailedOnfido) { 
        
               return ( 
        
                   <View style={alertViewStyle}> 
        
                       <Icon 
        
                           src={Expensicons.Exclamation} 
        
                           fill={theme.icon} 
        
                       /> 
        
                       <Text style={alertTextStyle}>{translate('walletPage.walletActivationFailed')}</Text> 
        
                   </View> 
        
               ); 
        
           }

What changes do you think we should make in order to solve the problem?

ph5 is not needed here, we can remove it:

const alertViewStyle = [styles.flexRow, styles.alignItemsCenter, styles.w100, styles.ph5];

@shawnborton

@shawnborton Is it happening always, any idea why it's marked as "Needs reproduction"?

I think because you need to go through a US wallet enablement flow to trigger it. But as long as we can force the condition on the front end to test, I think we'll be okay.

@muttmuure

@muttmuure Can you have a look?

Hm, I don't think I can do this easily. I'm not a US resident so I can't queue this up

So can someone else be assigned as BZ ?

@eVoloshchak

Not overdue, payment is due tomorrow.

@eVoloshchak can you please handle the BZ checklist? Thanks!

While I agree that this change wouldn't normally pay $250, I'm actually going to switch the price back to $250 on this one since the Upwork offer was sent before changing the price.

Upwork job price has been updated to $250

@ShridharGoel

Summarizing payment on this issue:

Contributor: @ShridharGoel $250, paid via Upwork
Contributor+: @eVoloshchak $250, please request on Newdot

@eVoloshchak

@eVoloshchak please complete the BZ checklist so we can close this one out. Thanks 🙏

Bumped on Slack.

The PR that introduced the bug has been identified. Link to the PR: [CP staging] Prevent second attempts to activate wallet when Onfido checks fail #30114
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30114/files#r1704440630
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: this is a simple visual bug, additional discussion isn't needed

Regression Test Proposal

Go to Expensify app.
Go to settings > Wallet.
Enable Wallet -> Go through the process of adding a bank account
Notice the message "We're reviewing your information, please check back in a few minutes!".
Verify there is no extra padding, text is aligned with the balance above

Do we agree 👍 or 👎

Thanks! I created the issue to add new regression test steps.

@eVoloshchak

$250 approved for @eVoloshchak

Navigation Menu

Repository navigation

[HOLD for payment 2024-08-01] [$250] Wallet : Incorrect padding on "we're reviewing..." label #44773

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

43 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isPendingOnfidoResult) {
	return (
	<View style={alertViewStyle}>
	<Icon
	src={Expensicons.Hourglass}
	fill={theme.icon}
	/>

	<Text style={alertTextStyle}>{translate('walletPage.walletActivationPending')}</Text>
	</View>
	);
	}

	if (hasFailedOnfido) {
	return (
	<View style={alertViewStyle}>
	<Icon
	src={Expensicons.Exclamation}
	fill={theme.icon}
	/>

	<Text style={alertTextStyle}>{translate('walletPage.walletActivationFailed')}</Text>
	</View>
	);
	}

[HOLD for payment 2024-08-01] [$250] Wallet : Incorrect padding on "we're reviewing..." label #44773

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 3, 2024

MelvinBot commented on Jul 3, 2024

ShridharGoel commented on Jul 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

ShridharGoel commented on Jul 3, 2024

shawnborton commented on Jul 3, 2024

ShridharGoel commented on Jul 5, 2024

muttmuure commented on Jul 8, 2024

ShridharGoel commented on Jul 8, 2024

43 remaining items

sakluger commented on Jul 31, 2024

sakluger commented on Aug 1, 2024

melvin-bot commented on Aug 1, 2024

sakluger commented on Aug 1, 2024

sakluger commented on Aug 1, 2024

sakluger commented on Aug 5, 2024

eVoloshchak commented on Aug 5, 2024

sakluger commented on Aug 5, 2024

JmillsExpensify commented on Aug 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions