Skip to content

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [$250] Comment link - Navigating to a report action comment doesn't scroll the report page #44625

Closed
Closed
[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [$250] Comment link - Navigating to a report action comment doesn't scroll the report page#44625
Assignees
bondydaaslafortunerayane-d
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Description

@lanitochka17
lanitochka17
opened on Jun 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.3-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Open a chat with a user and send a lot of comments so that there is a scrollable history
  3. Go to the top comment and copy the link to that comment
  4. Open another chat and navigate to the copied link

Expected Result:

The chat page scrolls to that specific comment

Actual Result:

The report page opens up but doesn't scroll to the specific comment

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6527366_1719577792343.bandicam_2024-06-28_15-24-59-313.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016eb6bedcd3171adc
  • Upwork Job ID: 1808449293455136963
  • Last Price Increase: 2024-07-03
Issue OwnerCurrent Issue Owner: @slafortune

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jun 28, 2024
  2. melvin-bot
    assigned
    bondydaa
    on Jun 28, 2024

  3. melvin-bot commented on Jun 28, 2024

    @melvin-bot
    melvin-botbot
    on Jun 28, 2024 – with Melvin Bot

    Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Jun 28, 2024

  5. github-actions commented on Jun 28, 2024

    @github-actions
    github-actionsbot
    on Jun 28, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. lanitochka17 commented on Jun 28, 2024

    @lanitochka17
    lanitochka17
    on Jun 28, 2024
    Author

    @bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  7. lanitochka17 commented on Jun 28, 2024

    @lanitochka17
    lanitochka17
    on Jun 28, 2024
    Author

    We think that this bug might be related to #vip-vsp

  8. bondydaa
    removed
    DeployBlockerIndicates it should block deploying the API
    on Jun 28, 2024

  9. bondydaa commented on Jun 28, 2024

    @bondydaa
    bondydaa
    on Jun 28, 2024
    Contributor

    i'm pretty sure if this only happens on web then it's most likely an app thing and not a web deploy problem.

  10. srikarparsi commented on Jun 28, 2024

    @srikarparsi
    srikarparsi
    on Jun 28, 2024
    Contributor

    Hey @nkdengineer and @mollfpr, could you take a look if this regression is from this PR whenever you have a chance?

  11. bondydaa commented on Jun 28, 2024

    @bondydaa
    bondydaa
    on Jun 28, 2024
    Contributor

    ☝️. that PR is the only one that stood out to me from the checklist that looks like it might be related to comment linking in some way so i'd ping'd srikar 1:1.

  12. nkdengineer commented on Jun 29, 2024

    @nkdengineer
    nkdengineer
    on Jun 29, 2024
    Contributor

    @srikarparsi I tried to revert my PR and it doesn't fix this issue. Correct me if I missed something.

  13. tsa321 commented on Jun 29, 2024

    @tsa321
    tsa321
    on Jun 29, 2024 · Hidden as resolved

  14. 51 remaining items

  15. bondydaa commented on Jul 16, 2024

    @bondydaa
    bondydaa
    on Jul 16, 2024
    Contributor

    adding BZ for payment, I think just @rayane-djouah for PR reviewing/testing right?

  16. melvin-bot
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jul 17, 2024
  17. melvin-bot
    changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [$250] Comment link - Navigating to a report action comment doesn't scroll the report page[/-] [+][HOLD for payment 2024-07-24] [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [$250] Comment link - Navigating to a report action comment doesn't scroll the report page[/+] on Jul 17, 2024

  18. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botbot
    on Jul 17, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Jul 17, 2024

    @melvin-bot
    melvin-botbot
    on Jul 17, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
    • [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rayane-djouah] Determine if we should create a regression test for this bug.
    • [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  20. slafortune commented on Jul 18, 2024

    @slafortune
    slafortune
    on Jul 18, 2024
    Contributor

    @rayane-djouah - offer sent here

    Can you please complete the checklist?

  21. rayane-d commented on Jul 20, 2024

    @rayane-d
    rayane-d
    on Jul 20, 2024
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Fix deep linking to reports after signing in #43307
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43307/files#r1685456779
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. There is already a regression test for this.
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

  22. rayane-d commented on Jul 20, 2024

    @rayane-d
    rayane-d
    on Jul 20, 2024
    Contributor

    @slafortune - Offer accepted and checklist completed. Thanks!

  23. slafortune commented on Jul 22, 2024

    @slafortune
    slafortune
    on Jul 22, 2024
    Contributor

    Paid ✅

  24. slafortune
    closed this as completedon Jul 22, 2024
  25. github-project-automation
    moved this from CRITICAL to Done in [#whatsnext] #qualityon Jul 22, 2024
  26. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions