Repository navigation
[HOLD for payment 2024-07-17] Track expense - "Hold" option should not appear for tracked expense in combined report #44617
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0-3.2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com/
- Go to workspace chat that has no unsettled expense
- Go to + > Track expense
- Track a manual expense
- Go to transaction thread (combined report)
- Click 3-dot menu
- Note that Hold option is available for tracked expense in the combined report
- Submit another expense
- Go to transaction thread of the tracked expense in Step 4
- Click 3-dot menu
- Note that Hold option is actually not available for tracked expense (this is the correct behavior)
Expected Result:
In Step 7, in one-report combined view, "Hold" option should not show up for the tracked expense
Actual Result:
In Step 7, in one-report combined view, "Hold" option shows up for the tracked expense in 3-dot menu
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Jun 28, 2024
Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Jun 28, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Jun 28, 2024
@NikkiWines FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Jun 28, 2024
We think that this bug might be related to #wave-collect - Release 1
NikkiWines commentedon Jun 28, 2024
This is almost certainly from #43618. I don't think this should be a blocker even if the behavior isn't what we intend though, it's fairly low impact and doesn't come across as "buggy".
@trjExpensify just to confirm, do you think we should show the
HOLDoption for Track expenses? If not, let's open a new issue to rectify this rather than reverting the whole PR.trjExpensify commentedon Jun 28, 2024
@NikkiWines I don't think you should be able to hold expenses in your selfDM. They should be immediately added to a closed report and there's nothing to do or prevent. 👍
NikkiWines commentedon Jun 28, 2024
Cool, I can spin up an issue or PR to handle this, but removing the blocker label for now 👍
26 remaining items
[-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Track expense - "Hold" option should not appear for tracked expense in combined report[/-][+][HOLD for payment 2024-07-17] Track expense - "Hold" option should not appear for tracked expense in combined report[/+]lschurr commentedon Jul 16, 2024
This is due payment tomorrow - https://expensify.slack.com/archives/C01SKUP7QR0/p1721171565737339
lschurr commentedon Jul 17, 2024
Payment summary:
akinwale commentedon Jul 17, 2024
@lschurr I am not eligible for NewDot payments until late October, so I still need to be paid through Upwork for this one.
lschurr commentedon Jul 17, 2024
Ah, ok the automation is incorrect in this case. I'll create an Upwork job.
melvin-bot commentedon Jul 17, 2024
Payment Summary
Upwork Job
BugZero Checklist (@lschurr)
lschurr commentedon Jul 17, 2024
Offer sent in Upwork @akinwale - https://www.upwork.com/nx/wm/offer/103161072
lschurr commentedon Jul 17, 2024
All set!