[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Netsuite - Categories copy mentions "Xero settings" instead of "NetSuite" settings

@sobitneupane

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0-3.1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #44038

Action Performed:

Precondition:

Account is connected to NetSuite (set up from OD)

Go to staging.new.expensify.com
Go to Workspace settings > Categories

Expected Result:

The Categories copy should mention "NetSuite settings"

Actual Result:

The Categories copy should mention "NetSuite settings"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6526876_1719533676797.20240628_081049.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012bfdd3cfbe5588a2
Upwork Job ID: 1806537315771441691
Last Price Increase: 2024-06-28

Issue Owner

Current Issue Owner: @sobitneupane

@robertjchen

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@robertjchen

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 2

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories copy mentions "Xero settings" instead of "NetSuite" settings

What is the root cause of that problem?

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 270 in 1d607ac

    
           {`${translate(isConnectedToQbo ? 'workspace.accounting.qbo' : 'workspace.accounting.xero')} ${translate('workspace.accounting.settings')}`}

this code only handling Xero and Quickbooks, it will always show Xero if not connected to Quickbooks

What changes do you think we should make in order to solve the problem?

add new const isConnectedToXero on WorkspaceCategoriesPage

const isConnectedToXero = !!policy?.connections?.xero;

change this code to the following code to handle Xero, Quickbooks, and NetSuite

{`${translate(isConnectedToQbo ? 'workspace.accounting.qbo' : isConnectedToXero ? 'workspace.accounting.xero' : 'workspace.accounting.netsuite')} ${translate('workspace.accounting.settings')}`}

Need to update the following too:

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 283 in 1d607ac

    
           {`${translate(isConnectedToQbo ? 'workspace.accounting.qbo' : 'workspace.accounting.xero')} ${translate('workspace.accounting.settings')}`}

App/src/pages/workspace/taxes/WorkspaceTaxesPage.tsx

Line 255 in 1d607ac

    
           {`${translate(isConnectedToQbo ? 'workspace.accounting.qbo' : 'workspace.accounting.xero')} ${translate('workspace.accounting.settings')}`}

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Lines 28 to 34 in 1d607ac

    
           let toggleSubtitle = ''; 
        
           if (isConnectedToQbo) { 
        
               toggleSubtitle = `${translate('workspace.categories.needCategoryForExportToIntegration')} ${translate('workspace.accounting.qbo')}.`; 
        
           } 
        
           if (isConnectedToXero) { 
        
               toggleSubtitle = `${translate('workspace.categories.needCategoryForExportToIntegration')} ${translate('workspace.accounting.xero')}.`; 
        
           }

What alternative solutions did you explore? (Optional)

create the following reusable function on PolicyUtils and implement it in all codes above

function getConnectionTypeTranslationKey(connections: Connections | undefined): TranslationPaths {
    if (connections?.quickbooksOnline) {
        return 'workspace.accounting.qbo';
    } else if (connections?.xero) {
        return 'workspace.accounting.xero';
    } else {
        return 'workspace.accounting.netsuite';
    }
}

Use it like this:

{`${translate(PolicyUtils.getConnectionTypeTranslationKey(policy?.connections))} ${translate('workspace.accounting.settings')}`}

Reviewing label has been removed, please complete the "BugZero Checklist".

@mananjadhav

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[#Wave-Control: Add NetSuite]: Fix Connection name on Workspace pages. #44664

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

@mananjadhav requires payment through NewDot Manual Requests

@mananjadhav

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[#Wave-Control: Add NetSuite]: Fix Connection name on Workspace pages. #44664

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@mananjadhav requires payment through NewDot Manual Requests

This will be paid out centrally so we are good to close this one out.

thanks!

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Netsuite - Categories copy mentions "Xero settings" instead of "NetSuite" settings #44591

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	let toggleSubtitle = '';
	if (isConnectedToQbo) {
	toggleSubtitle = `${translate('workspace.categories.needCategoryForExportToIntegration')} ${translate('workspace.accounting.qbo')}.`;
	}
	if (isConnectedToXero) {
	toggleSubtitle = `${translate('workspace.categories.needCategoryForExportToIntegration')} ${translate('workspace.accounting.xero')}.`;
	}

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Netsuite - Categories copy mentions "Xero settings" instead of "NetSuite" settings #44591

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 28, 2024

github-actions commented on Jun 28, 2024

lanitochka17 commented on Jun 28, 2024

lanitochka17 commented on Jun 28, 2024

nyomanjyotisa commented on Jun 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

23 remaining items

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 10, 2024

melvin-bot commented on Jul 15, 2024

mananjadhav commented on Jul 16, 2024

robertjchen commented on Jul 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions