Skip to content

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Clicking on the sub header to back from the report details chat does not load  #44513

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1719420494317139

Action Performed:

  1. User A submits a report to a workspace
  2. As a approver user B open the report to view the expense details
  3. Click on the sub header to go back to the report chat

Expected Result:

Chat report should with all the expenses submitted

Actual Result:

Empty page appears and has to click on the chat again at the LHN to view the chats

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-06-26_09-45-26.mp4

logs-2024-06-26 16_45_02.769.txt

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. melvin-bot commented on Jun 27, 2024

    @melvin-bot

    Triggered auto assignment to @pecanoro (AutoAssignerNewDotQuality)

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Jun 27, 2024
  3. melvin-bot commented on Jun 27, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. MelvinBot commented on Jun 27, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  5. 11 remaining items

  6. kadiealexander commented on Jul 8, 2024

    @kadiealexander
    Contributor

    Cool! Closing for now, please reopen if it comes back!

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 10, 2024
  8. changed the title [-]Clicking on the sub header to back from the report details chat does not load [/-] [+][HOLD for payment 2024-07-17] Clicking on the sub header to back from the report details chat does not load [/+] on Jul 10, 2024
  9. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-17. 🎊

  10. melvin-bot commented on Jul 10, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
    • [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@youssef-lr] Determine if we should create a regression test for this bug.
    • [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. changed the title [-][HOLD for payment 2024-07-17] Clicking on the sub header to back from the report details chat does not load [/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Clicking on the sub header to back from the report details chat does not load [/+] on Jul 15, 2024
  12. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

  13. melvin-bot commented on Jul 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
    • [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@youssef-lr] Determine if we should create a regression test for this bug.
    • [@youssef-lr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffNeeds ReproductionReproducible steps neededWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions