Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense #44490
Description
Activity
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Same root cause with #44434
Interesting, the video that @m-natarajan posted doesn't actually have the bug. Maybe we need more clear reproduction steps here...
Ah yes @etCoderDysto - thanks for linking that, that does look like the issue.
Reacted by Night CoderNo problem 🙌
@anmurali Huh... This is 4 days overdue. Who can take care of this?
@anmurali Still overdue 6 days?! Let's take care of this!
@anmurali 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
- changed the title
[-]Extra margin below the header and above the expense information when viewing an expense[/-][+][HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/+]on Jul 10, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [] The PR that introduced the bug has been identified. Link to the PR:
- [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [] Determine if we should create a regression test for this bug.
- [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] Extra margin below the header and above the expense information when viewing an expense[/+]on Jul 15, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [] The PR that introduced the bug has been identified. Link to the PR:
- [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [] Determine if we should create a regression test for this bug.
- [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.2-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719404177176039
Action Performed:
Expected Result:
No extra margin below header and expense details
Actual Result:
Extra margin below header and expense details
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
RPReplay_Final1719404148.MP4
RPReplay_Final1719420617.MP4
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @anmurali