Repository navigation
[HOLD for payment 2024-08-19] Investigate improvements of the react-compiler #44384
Description
We recently added react-compiler to the codebase; however, a healthcheck shows that only 937 out of 1235 files are actually compiled.
We need to understand why other ~300 components can not be compiled. At the moment we think that it could be:
- because they are very complex for the compiler
- break rules of the React
- already optimized very well, so compiler can skip them
To figure out an exact reason we need to have verbose logging in the healthcheck. There is several PRs:
- compiler: add verbose logging to
react-compiler-healthcheckreact/react#29080 - Add verbose error logging option to react-compiler-healthcheck react/react#29851
We can apply the patch package locally or wait until one of these PRs is merged and a new version is published.
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
kirillzyusko commentedon Jun 25, 2024
I can work on this 👀
melvin-bot commentedon Jul 15, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jul 22, 2024
This issue has not been updated in over 15 days. @kirillzyusko, @mountiny eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
mountiny commentedon Jul 22, 2024
@kirillzyusko Any updates on this one?
kirillzyusko commentedon Jul 24, 2024
@mountiny I think it can be closed because #44460 was merged 👀
mountiny commentedon Jul 25, 2024
Thanks! gonna keep it open now for a bit as we got the second pr
[-]Investigate improvements of the react-compiler [/-][+][HOLD for payment 2024-08-19] Investigate improvements of the react-compiler [/+]melvin-bot commentedon Aug 12, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.18-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
react-compilerchecks 🧬 #45998If no regressions arise, payment will be issued on 2024-08-19. 🎊
For reference, here are some details about the assignees on this issue:
mountiny commentedon Aug 12, 2024
@kirillzyusko anything else to explore for this task?
kirillzyusko commentedon Aug 12, 2024
@mountiny I think no 🙂
mountiny commentedon Aug 12, 2024
thank you