Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Payment card / Subscription] fix card data not showing up in the new subscription page #44362
Description
Problem
Right now if you add a card to your existing subscription via https://dev.new.expensify.com:8082/settings/subscription/add-payment-card it'll not show anything. There are multiple issues here causing this, but they are small enough to be combined into this one use case.
The first problem is explained in this slack thread. Basically we are not properly initializing the fundList in the Onyx db on the client. We need to fix that.
The second problem is that after this was completed we never updated App's code to make use of the new format of the data, which means it doesn't show the default card.
Solution
Fix both of the described problems above and make a newly added payment card show up in the UI.
Activity
blimpich commentedon Jun 25, 2024
Web-PR is in review, App PR is on hold until Web-PR is merged and deployed
blimpich commentedon Jun 25, 2024
Web PR is merged, waiting deploy.
App PR is in review, waiting approval but also waiting web changes to be deployed before a proper review can happen.
blimpich commentedon Jun 26, 2024
Web PR was deployed to staging, waiting deploy to production
trjExpensify commentedon Jul 2, 2024
App PR has merged: #44361
Adding labels to get a BZ assigned, and @brunovjk as the C+ reviewer.
17 remaining items
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
pac-guerreiro commentedon Jul 20, 2024
Hey, this line of code was missed in @blimpich PR - https://github.com/Expensify/App/blob/main/src/libs/SubscriptionUtils.ts#L206
Not his fault, this one was sneaky 😅
The specific line of code doesn't cause the error reported in this issue but it will not trigger card expired related UI.
I can create a PR for this if you want 😄
blimpich commentedon Jul 22, 2024
Ah, thank you for catching that @pac-guerreiro! I'll make a quick issue/PR for it right now 👍
blimpich commentedon Jul 22, 2024
Created issue here for tracking this follow up. PR is up and I'm gonna do some testing before getting it out for review.
blimpich commentedon Jul 22, 2024
Also no regression tests should be needed for this issue. @abekkala correct me if I'm wrong but I think we need to pay @brunovjk for reviewing this PR? I think that was my mistake for closing this PR too soon.
abekkala commentedon Jul 23, 2024
@blimpich ah yes, I can send payment offer to @brunovjk for reviewing this PR: #44361
I assume that is a $250 review?
blimpich commentedon Jul 23, 2024
Yes $250
abekkala commentedon Jul 23, 2024
@brunovjk offer sent!
brunovjk commentedon Jul 23, 2024
thank you all :D
abekkala commentedon Jul 23, 2024
@brunovjk payment sent and contract ended - thank you! 🎉