[HOLD for payment 2024-07-17] [$250] Troubleshoot - Troubleshoot modal opened from shortcut is missing Testing preferences

@anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.0.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause -Internal Team

Issue found when executing PR #43543

Action Performed:

Go to staging.new.expensify.com
Press CMD + D

Expected Result:

Troubleshoot modal opened from shortcut will be complete

Actual Result:

Troubleshoot modal opened from shortcut is missing Testing preferences

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6520668_1718987164941.20240622_002210.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a41f20c0677b7543
Upwork Job ID: 1805670065479684749
Last Price Increase: 2024-06-25
Automatic offers:

allgandalf | Reviewer | 102915241
aeioual | Contributor | 102915244

Issue Owner

Current Issue Owner: @anmurali

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@anmurali

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Troubleshoot modal opened from shortcut is missing Testing preferences

What is the root cause of that problem?

The Testing preference on troubleshoot modal is only displayed if the environment is Development

App/src/components/TestToolsModal.tsx

Line 47 in b021195

{isDevelopment && <TestToolMenu />}

What changes do you think we should make in order to solve the problem?

Make the Testing preference on troubleshoot displayed if the environment is not Production, so it will be displayed on Development and Staging environment

What alternative solutions did you explore? (Optional)

Create a reusable component to display a list of troubleshooting configurations. This component will ensure that both the Troubleshoot modal and the Troubleshoot page consistently display the same configurations. It will also simplify the process of adding or modifying configurations in the future if needed.

Result:
https://github.com/Expensify/App/assets/73281575/e07b738a-ac78-4f09-98d1-e8e85bc28e2a

Proposal

Please re-state the problem that we are trying to solve in this issue.

Troubleshoot modal opened from shortcut is missing Testing preferences

What is the root cause of that problem?

We do not allow the testtoolMenu on staging, hence we do not see the options.

App/src/components/TestToolsModal.tsx

Line 47 in b021195

{isDevelopment && <TestToolMenu />}

I also found one more bug, the order of options is not right, we should first display the Logs options and then the TestToolMenu (We do the same with the troubleshoot page too):

As you can see the first option is of client side logging then the testing preference, we should maintain this order in shortcut too.

What changes do you think we should make in order to solve the problem?

Change the check to !isProduction from the following hook>

App/src/hooks/useEnvironment.ts

Line 16 in 425804a

isProduction: environment === CONST.ENVIRONMENT.PRODUCTION,
Then we should move the code block after the following line to match the UI with the troubleshoot page:

App/src/components/TestToolsModal.tsx

Lines 66 to 67 in b021195

    
               </TestToolRow> 
        
           )}

</TestToolRow>
                )}
                {!isProduction && <TestToolMenu />}

What alternative solutions did you explore? (Optional)

@anmurali

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

Job added to Upwork: https://www.upwork.com/jobs/~01a41f20c0677b7543

@allgandalf

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@allgandalf

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fixes: Troubleshoot modal opened from shortcut is missing Testing preferences #44666

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@allgandalf requires payment automatic offer (Reviewer)
@aeioual requires payment automatic offer (Contributor)

@allgandalf

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@allgandalf] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Regression Test Proposal

Note: Can only test on Desktop/MacOS Web:

Open App
Press CMD + D

Verify that the Troubleshoot modal opens up

Do we agree 👍 or 👎

@anmurali

Note

@anmurali , this is already ready for payment, melvin really is acting weird, the actual date for payment was 15th

Waiting for payment!

@bondydaa

@bondydaa, @anmurali, @allgandalf, @aeioual Whoops! This issue is 2 days overdue. Let's get this updated quick!

This issue can be closed, payment has been completed

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] [$250] Troubleshoot - Troubleshoot modal opened from shortcut is missing Testing preferences #44178

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

34 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-07-17] [$250] Troubleshoot - Troubleshoot modal opened from shortcut is missing Testing preferences #44178

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 21, 2024

lanitochka17 commented on Jun 21, 2024

nyomanjyotisa commented on Jun 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

aeioual commented on Jun 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jun 25, 2024

melvin-bot commented on Jun 25, 2024

melvin-bot commented on Jun 25, 2024

34 remaining items

melvin-bot commented on Jul 15, 2024

melvin-bot commented on Jul 15, 2024

allgandalf commented on Jul 16, 2024

Regression Test Proposal

allgandalf commented on Jul 16, 2024

allgandalf commented on Jul 19, 2024

melvin-bot commented on Jul 19, 2024

allgandalf commented on Jul 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions