Skip to content

[$250] [HOLD for payment] [Details Revamp] Allow Editing Report Title from Details Page #44149

Closed
Closed
[$250] [HOLD for payment] [Details Revamp] Allow Editing Report Title from Details Page#44149
Assignees
grgiakadiealexandercdOutishpaul777dubielzyk-expensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNewFeatureSomething to build that is a new item.WeeklyKSv2

Description

@grgia
grgia
opened on Jun 21, 2024

Problem

image

We currently display the report title as shown above. This is now inconsistent with our new details revamp project.

Solution

image

Make the report title editor available from the details page for those with correct permissions. Remove it from the report body as shown in the previous screenshot.

So for example, members, approvers and admins can change the report title. Anyone added to the room, not part of the approval workfllow, should not be able to change the report title.

We will use our typical push to page pattern for this change.

Slack thread

https://expensify.slack.com/archives/C036QM0SLJK/p1718830874704809?thread_ts=1718719187.256049&cid=C036QM0SLJK

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cc27f37e79795306
  • Upwork Job ID: 1813753312852314259
  • Last Price Increase: 2024-07-18
Issue OwnerCurrent Issue Owner: @ishpaul777

Activity

  1. grgia
    added
    DailyKSv2
    NewFeatureSomething to build that is a new item.
    on Jun 21, 2024
  2. grgia
    self-assigned this
    on Jun 21, 2024

  3. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    Triggered auto assignment to @kadiealexander (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  4. melvin-bot
    assigned
    kadiealexander
    on Jun 21, 2024
  5. melvin-bot
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jun 21, 2024

  6. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  7. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  8. melvin-bot
    assigned
    dubielzyk-expensify
    on Jun 21, 2024
  9. trjExpensify
    added this to [#whatsnext] #wave-collecton Jun 21, 2024
  10. trjExpensify
    moved this to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collecton Jun 21, 2024

  11. cdOut commented on Jun 21, 2024

    @cdOut
    cdOut
    on Jun 21, 2024
    Contributor

    Hi, I’m Tymoteusz from Software Mansion, the expert agency, and I’ll be working on this issue.

  12. grgia
    assigned
    cdOut
    on Jun 21, 2024

  13. ishpaul777 commented on Jun 22, 2024

    @ishpaul777
    ishpaul777
    on Jun 22, 2024
    Contributor

    I am low on issues, just incase we need a c+ for this issue i'd love to help

  14. 35 remaining items

  15. kadiealexander commented on Jul 26, 2024

    @kadiealexander
    kadiealexander
    on Jul 26, 2024
    Contributor

    @ishpaul777 please accept the upwork offer.

  16. melvin-bot
    removed
    Overdue
    on Jul 26, 2024

  17. ishpaul777 commented on Jul 27, 2024

    @ishpaul777
    ishpaul777
    on Jul 27, 2024
    Contributor

    Hey @kadiealexander Would you please hold my payment for few days, i have had my payments on HOLD across issues i'll bump once i am ready to accept payment.

    Reason: #44029 (comment)

  18. kadiealexander
    changed the title [-][$250] [HOLD for payment 2024-07-17] [Details Revamp] Allow Editing Report Title from Details Page[/-] [+][$250] [HOLD for payment] [Details Revamp] Allow Editing Report Title from Details Page[/+] on Jul 28, 2024
  19. melvin-bot
    added
    Overdue
    on Jul 28, 2024

  20. kadiealexander commented on Jul 28, 2024

    @kadiealexander
    kadiealexander
    on Jul 28, 2024
    Contributor

    No worries!

  21. melvin-bot
    removed
    Overdue
    on Jul 28, 2024
  22. kadiealexander
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jul 28, 2024

  23. ishpaul777 commented on Aug 9, 2024

    @ishpaul777
    ishpaul777
    on Aug 9, 2024
    Contributor

    Still hold

  24. ishpaul777 commented on Aug 14, 2024

    @ishpaul777
    ishpaul777
    on Aug 14, 2024
    Contributor

    Thanks for patience here @kadiealexander, please release payment when you get the chance

  25. kadiealexander
    closed this as completedon Sep 3, 2024
  26. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Sep 3, 2024
  27. github-project-automation
    moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collecton Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions