[HOLD for payment 2024-07-17] [$250] Task – Green dot disappears with a delay in LHN when task is completed

@zanyrenney

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.86-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4647657
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Go to https://staging.new.expensify.com/
Log in as user A
Create a task without assignee in a room, where user B is a member
Log in as user B
Open task and assign it to yourself
Find task in LHN and verify green dot appears
Mark task as complete

Expected Result:

Green dot disappears without delay in LHN when task is completed

Actual Result:

Green dot disappears with a delay in LHN when task is completed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6519414_1718889153740.Green_dot.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fd4e242d6ffc4ea6
Upwork Job ID: 1804185858023926931
Last Price Increase: 2024-06-21
Automatic offers:

bernhardoj | Contributor | 102916582

Issue Owner

Current Issue Owner: @zanyrenney

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@zanyrenney

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsb

Proposal

Please re-state the problem that we are trying to solve in this issue.

The green dot in LHN doesn't immediately disappear when completing a task.

What is the root cause of that problem?

There are multiple conditions for the green dot to show, but in our case, we just focus on these 2 conditions.

App/src/libs/ReportUtils.ts

Lines 2316 to 2322 in 633e708

    
           if (isUnreadWithMention(optionOrReport)) { 
        
               return true; 
        
           } 
        
           if (isWaitingForAssigneeToCompleteTask(optionOrReport, parentReportAction)) { 
        
               return true; 
        
           }

isUnreadWithMention will be true if the lastReadTime is smaller than the lastMentionedTime. A new task report doesn't have a lastReadTime. When we assign a task to ourselves, a new message is shown
assigned to {mention}
which adds a mention to ourselves. So, the lastMentionedTime returns from the EditTaskAssignee API.

Because the lastReadTime is empty and defaults to an empty string, it's smaller than the lastMentionedTime. This makes the LHN title bold too (unread).

App/src/libs/ReportUtils.ts

Lines 2288 to 2290 in 633e708

    
           const lastMentionedTime = reportOrOption.lastMentionedTime ?? ''; 
        
           const lastReadTime = reportOrOption.lastReadTime ?? ''; 
        
           return !!('isUnreadWithMention' in reportOrOption && reportOrOption.isUnreadWithMention) || lastReadTime < lastMentionedTime;

When we complete the task, isWaitingForAssigneeToCompleteTask returns false, but isUnreadWithMention still returns true. After a few seconds, the CompleteTask API returns the up-to-date lastReadTime which hides the green dot.

What changes do you think we should make in order to solve the problem?

I think we have 2 issues here. The LHN becomes unread when assigning a task to ourselves and the green dot and unread don't immediately disappear after completing a task.

To fix the second issue, we can optimistically set a lastReadTime when completing the task.

App/src/libs/actions/Task.ts

Lines 302 to 315 in 633e708

    
           function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>) { 
        
               const taskReportID = taskReport?.reportID ?? '-1'; 
        
               const message = `marked as complete`; 
        
               const completedTaskReportAction = ReportUtils.buildOptimisticTaskReportAction(taskReportID, CONST.REPORT.ACTIONS.TYPE.TASK_COMPLETED, message); 
        
               const optimisticData: OnyxUpdate[] = [ 
        
                   { 
        
                       onyxMethod: Onyx.METHOD.MERGE, 
        
                       key: `${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`, 
        
                       value: { 
        
                           stateNum: CONST.REPORT.STATE_NUM.APPROVED, 
        
                           statusNum: CONST.REPORT.STATUS_NUM.APPROVED, 
        
                       }, 
        
                   },

lastReadTime: DateUtils.getDBTime(),

(and revert it back when it fails)

For the first issue, I think it requires both FE and BE fix. On FE, we can optimistically update the lastReadTime just like above when editing the assignee (or other fields). However, this isn't enough because the lastMentionedTime from EditTaskAssignee will still be bigger than the optimistic lastReadTime. So, I think the EditTaskAssignee API should return both lastReadTime and lastMentionedTime and have them at least equal.

Yes this looks VSB related, lets get this fixed!

Job added to Upwork: https://www.upwork.com/jobs/~01fd4e242d6ffc4ea6

@allroundexperts

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@allroundexperts

@allroundexperts, @zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Requested in ND

@allroundexperts

payment summary

@allroundexperts requires payment through NewDot Manual Requests - please request $250 via ND
@bernhardoj requires payment automatic offer (Contributor) - please ignore upwork offer as i see you are paid via ND. please request $250 via ND

@bernhardoj

$250 approved for @bernhardoj

Checklist

I was not able to pinpoint any specific PR which caused this. The logic for green dot is dependent on many conditions and it is highly likely that multiple changes lead up to this.
N/A
N/A
A regression test would be helpful here.

Regression test

Open the app and login as user A
Create a room and add a user B to it
Create a task in the room and do not add any assignee to it
Login as user B
Open the task that was created in step 3 and assign it to yourself
Find task in LHN and verify green dot appears
Mark task as complete

Verify that the green dot disappears without delay in LHN when task is completed

Do we 👍 or 👎 ?

@allroundexperts

$250 approved for @allroundexperts

Opening this back up for the regression test.

@JmillsExpensify

My b, thanks @JmillsExpensify

Navigation Menu

Repository navigation

[HOLD for payment 2024-07-17] [$250] Task – Green dot disappears with a delay in LHN when task is completed #44087

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

34 remaining items

Checklist

Regression test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (isUnreadWithMention(optionOrReport)) {
	return true;
	}

	if (isWaitingForAssigneeToCompleteTask(optionOrReport, parentReportAction)) {
	return true;
	}

	const lastMentionedTime = reportOrOption.lastMentionedTime ?? '';
	const lastReadTime = reportOrOption.lastReadTime ?? '';
	return !!('isUnreadWithMention' in reportOrOption && reportOrOption.isUnreadWithMention) \|\| lastReadTime < lastMentionedTime;

	function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>) {
	const taskReportID = taskReport?.reportID ?? '-1';
	const message = `marked as complete`;
	const completedTaskReportAction = ReportUtils.buildOptimisticTaskReportAction(taskReportID, CONST.REPORT.ACTIONS.TYPE.TASK_COMPLETED, message);

	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${taskReportID}`,
	value: {
	stateNum: CONST.REPORT.STATE_NUM.APPROVED,
	statusNum: CONST.REPORT.STATUS_NUM.APPROVED,
	},
	},

[HOLD for payment 2024-07-17] [$250] Task – Green dot disappears with a delay in LHN when task is completed #44087

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jun 20, 2024

m-natarajan commented on Jun 20, 2024

m-natarajan commented on Jun 20, 2024

bernhardoj commented on Jun 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

zanyrenney commented on Jun 21, 2024

melvin-bot commented on Jun 21, 2024

melvin-bot commented on Jun 21, 2024

melvin-bot commented on Jun 24, 2024

34 remaining items

bernhardoj commented on Jul 17, 2024

zanyrenney commented on Jul 19, 2024

JmillsExpensify commented on Jul 19, 2024

allroundexperts commented on Jul 28, 2024

Checklist

Regression test

JmillsExpensify commented on Aug 21, 2024

JmillsExpensify commented on Aug 21, 2024

zanyrenney commented on Aug 22, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions