[Pay 9/6] Clearing the comment while Editing will show (edited) for a brief time period

[aman-atg]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login to newDot
2. Go to any chat
3. Edit your comment and delete everything in it
4. (edited) will be shown for a few ms

Expected Result:

Nothing should be shown

Actual Result:

editBug.mp4

Workaround:

Visual Issue.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[aman-atg]

Proposal

• This situation can be handled inside src/libs/actions/Report..js.
  

  App/src/libs/actions/Report.js

  Lines 1265 to 1270 in f772837

  	function editReportComment(reportID, originalReportAction, textForNewComment) {
  	const parser = new ExpensiMark();
  	const htmlForNewComment = parser.replace(textForNewComment);
  	// Skip the Edit if message is not changed
  	if (originalReportAction.message[0].html === htmlForNewComment.trim()) {

• We can add the below code after line 1268 so that we don't flag the comment as edited when it's actually empty/deleted

    //  Delete the comment if it's empty
    if (_.isEmpty(htmlForNewComment)) {
        deleteReportComment(reportID, originalReportAction);
        return;
    }

[MelvinBot]

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Holding for a weekish