You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [FT] Add deeplinks to workspace editor in the onboarding checklist tasks #44017
Problem: In the onboarding checklist for new users on New Expensify, there are a handful of directions on each task that require a member to switch between the task's instructions and actually getting to the place in the product that the instructions mention.
Solution: Let's add a deeplink directly to the member's workspace editor so that they can more easily follow the instructions and skip a few steps to get the task completed.
Context:
To get to the screen(s) we want to add deeplinks to: A new user signs up, selects "Manage my team's expenses" in the intent selection modal > enters their business name in "where do you work" > Enters their name in "what's your name" > clicks "Get Started" on the onboarding video modal > Then, the user is shown the onboarding checklist. There are 3 tasks that require navigating to the workspace editor where we would add a deeplink directly to the member's workspace.
Where the deeplink should go:
The three onboarding tasks that should include a deeplink: "Set up categories", "Add expense approvals", and "Invite your team"
As you can see in the screenshot attached below, step 2 for each of the 3 tasks mentioned above is where we can include a deeplink to the workspace editor:
Go to Workspaces > [your workspace] [your workspace] should be where the deeplink to the workspace editor is located. Also, note that the link should be using the production URL.
changed the title [-]Add deeplinks to workspace editor in the onboarding checklist tasks[/-][+][$250] Add deeplinks to workspace editor in the onboarding checklist tasks[/+]on Jun 19, 2024
changed the title [-][HOLD for payment 2024-07-17] [$250] [FT] Add deeplinks to workspace editor in the onboarding checklist tasks[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [FT] Add deeplinks to workspace editor in the onboarding checklist tasks[/+]on Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
@mountiny I noticed in the PR that the fix seemed to be deployed again to prod (first deploy: July 10, second deploy: July 15). Do I need to wait until the 22nd to pay this out, or am I safe to release payment on July 17?
Activity
melvin-bot commentedon Jun 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0142e3df4eaf0fbe54
[-]Add deeplinks to workspace editor in the onboarding checklist tasks[/-][+][$250] Add deeplinks to workspace editor in the onboarding checklist tasks[/+]melvin-bot commentedon Jun 19, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)melvin-bot commentedon Jun 19, 2024
Triggered auto assignment to @johncschuster (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.35 remaining items
[-][HOLD for payment 2024-07-17] [$250] [FT] Add deeplinks to workspace editor in the onboarding checklist tasks[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [FT] Add deeplinks to workspace editor in the onboarding checklist tasks[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
johncschuster commentedon Jul 16, 2024
@mountiny I noticed in the PR that the fix seemed to be deployed again to prod (first deploy: July 10, second deploy: July 15). Do I need to wait until the 22nd to pay this out, or am I safe to release payment on July 17?
johncschuster commentedon Jul 17, 2024
Ah, it looks like our deploy process may be broken (Slack). I'm issuing payment today.
johncschuster commentedon Jul 17, 2024
I've issued payment to @nkdengineer. @shubham1206agra, can you please accept the linked job above so I can issue payment to you? Thank you!
shubham1206agra commentedon Jul 17, 2024
@johncschuster Accepted offer.
johncschuster commentedon Jul 18, 2024
Thank you! I've just issued payment. Do you think we need a regression test suite for this? If so, can you propose one?
shubham1206agra commentedon Jul 18, 2024
Test
Manage my team's expensesSet up categoriesGo to Workspaces > [your workspace]should deeplink to the workspace.