Skip to content

[HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone #43942

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.85-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4646136
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track a manual expense
  4. Click Submit it to someone from the actionable whisper
  5. Select a user

Expected Result:

There will be an option to add receipt on the confirmation page

Actual Result:

There is no option to add receipt on the confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6517560_1718732559665.bandicam_2024-06-19_01-40-29-806.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015c134d920ca4197c
  • Upwork Job ID: 1803928874102505326
  • Last Price Increase: 2024-06-20
  • Automatic offers:
    • hungvu193 | Reviewer | 102918536
    • nkdengineer | Contributor | 102918540
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 18, 2024
  2. melvin-bot commented on Jun 18, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Jun 18, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  4. lanitochka17 commented on Jun 18, 2024

    @lanitochka17
    Author

    @adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. adelekennedy commented on Jun 20, 2024

    @adelekennedy
    Contributor

    yep - I can reproduce, and in this case I agree this is a bug as we allow you to add a receipt after selecting the receiver from the global create

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 20, 2024
  7. changed the title [-]Actionable whisper - No option to add receipt when submitting to someone[/-] [+][$250] Actionable whisper - No option to add receipt when submitting to someone[/+] on Jun 20, 2024
  8. melvin-bot commented on Jun 20, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 20, 2024
  10. melvin-bot commented on Jun 20, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  11. 36 remaining items

  12. melvin-bot commented on Jul 19, 2024

    @melvin-bot

    @yuwenmemon, @hungvu193, @adelekennedy, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. adelekennedy commented on Jul 19, 2024

    @adelekennedy
    Contributor

    due to a bug a bunch of issue git hit with a double payment day but this should have been paid on the 17th - handling payment now!

  14. adelekennedy commented on Jul 19, 2024

    @adelekennedy
    Contributor

    Payouts due:

    Upwork job is here.

    bump also @nkdengineer complete the checklist above

  15. changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone[/-] [+][HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone[/+] on Jul 19, 2024
  16. hungvu193 commented on Jul 21, 2024

    @hungvu193
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Fix scan in progress shown for manual request with receipt moved from tracked expense #42984
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug.

    I don't think we need regression test for this one. Actually, this PR was revert becauseConvertTrackedExpenseToRequest command doesn't accept a receipt as a parameter, more details in this comment

  17. hungvu193 commented on Jul 23, 2024

    @hungvu193
    Contributor

    I'll request on ND later.

  18. hungvu193 commented on Jul 30, 2024

    @hungvu193
    Contributor

    Requested on ND

  19. JmillsExpensify commented on Jul 30, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions