You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone #43942
Version Number: 1.4.85-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/4646136 Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to self DM.
Track a manual expense
Click Submit it to someone from the actionable whisper
Select a user
Expected Result:
There will be an option to add receipt on the confirmation page
Actual Result:
There is no option to add receipt on the confirmation page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Actionable whisper - No option to add receipt when submitting to someone[/-][+][$250] Actionable whisper - No option to add receipt when submitting to someone[/+]on Jun 20, 2024
changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone[/-][+][HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone[/+]on Jul 19, 2024
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug.
I don't think we need regression test for this one. Actually, this PR was revert becauseConvertTrackedExpenseToRequest command doesn't accept a receipt as a parameter, more details in this comment
Activity
melvin-bot commentedon Jun 18, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Jun 18, 2024
We think that this bug might be related to #vip-vsp
lanitochka17 commentedon Jun 18, 2024
@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
adelekennedy commentedon Jun 20, 2024
yep - I can reproduce, and in this case I agree this is a bug as we allow you to add a receipt after selecting the receiver from the global create
[-]Actionable whisper - No option to add receipt when submitting to someone[/-][+][$250] Actionable whisper - No option to add receipt when submitting to someone[/+]melvin-bot commentedon Jun 20, 2024
Job added to Upwork: https://www.upwork.com/jobs/~015c134d920ca4197c
melvin-bot commentedon Jun 20, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)36 remaining items
melvin-bot commentedon Jul 19, 2024
@yuwenmemon, @hungvu193, @adelekennedy, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!
adelekennedy commentedon Jul 19, 2024
due to a bug a bunch of issue git hit with a double payment day but this should have been paid on the 17th - handling payment now!
adelekennedy commentedon Jul 19, 2024
Payouts due:
Upwork job is here.
bump also @nkdengineer complete the checklist above
[-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone[/-][+][HOLD for payment 2024-07-17] [$250] Actionable whisper - No option to add receipt when submitting to someone[/+]hungvu193 commentedon Jul 21, 2024
I don't think we need regression test for this one. Actually, this PR was revert because
ConvertTrackedExpenseToRequestcommand doesn't accept a receipt as a parameter, more details in this commenthungvu193 commentedon Jul 23, 2024
I'll request on ND later.
hungvu193 commentedon Jul 30, 2024
Requested on ND
JmillsExpensify commentedon Jul 30, 2024
$250 approved for @hungvu193