Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-28] mWeb - Room description - When saving specific room description different error shown in stg&pro #43925
Description
Activity
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Production:
@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
not a web blocker, looks like something changed in the error string being used.
that text comes from here https://github.com/Expensify/App/blob/main/src/components/Form/FormProvider.tsx#L146 but hasn't changed for ~6 months so something else seems to have changed.
@bondydaa It seems this was missed during this refactor: #42970
App/src/components/Form/FormProvider.tsx
Line 146 in cceb345
it should be updated as follows :
validateErrors[inputID] = translate('common.error.invalidCharacter');
Reacted by David Bondy13 remaining items
tested on staging and looking good 🎉
removing blocker
I think we can close this out since it was just a regression from #42970, let me know if that's wrong @nkdengineer or @fedirjh
Reacted by Fedi Rajhi- changed the title
[-]mWeb - Room description - When saving specific room description different error shown in stg&pro[/-][+][HOLD for payment 2024-06-28] mWeb - Room description - When saving specific room description different error shown in stg&pro[/+]on Jun 21, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @fedirjh requires payment (Needs manual offer from BZ)
- @nkdengineer requires payment (Needs manual offer from BZ)
- changed the title
[-][HOLD for payment 2024-06-28] mWeb - Room description - When saving specific room description different error shown in stg&pro[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-28] mWeb - Room description - When saving specific room description different error shown in stg&pro[/+]on Jun 21, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
- @fedirjh requires payment (Needs manual offer from BZ)
- @nkdengineer requires payment (Needs manual offer from BZ)
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.85
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4645733
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Same error must be shown in staging and production
Actual Result:
When saving specific room description different error shown in staging and production
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub