[HOLD] [Help Wanted for completing] [$250] LHN - System message remains on LHN when create new room via announce room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a256@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Create Workspace
2. Go to #announce room
3. Send a message "#room-1"
4. Verify that system message "Heads up, room-1 doesn't exist yet. Do you want to create it ?" appears
5. Click "Yes"
6. Verify that system message disappears from chat history
7. Take a look at #announce room in LHN

Expected Result:

System message should be dismissed

Actual Result:

System message "Heads up, room-1 doesn't exist yet. Do you want to create it ?" remains on LHN when create new room via announce room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6512441_1718312003111.Recording__3211.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0150a19511c968b1de
• Upwork Job ID: 1803219974130567450
• Last Price Increase: 2024-06-26
• Automatic offers:
• ishpaul777 | Contributor | 102911885
• dominictb | Contributor | 102941077

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - System message remains on LHN when create new room via announce room

What is the root cause of that problem?

The root cause of the problem is that the report lastMessageText is not cleared once the actionable whisper is acted upon.

App/src/libs/SidebarUtils.ts

Line 341 in 2e85794

const lastMessageTextFromReport = OptionsListUtils.getLastMessageTextForReport(report, lastActorDetails, policy);

Therefore, the result.alternateText will be the lastMessageText based on the following last else statement line in the SidebarUtils file.

App/src/libs/SidebarUtils.ts

Lines 387 to 392 in 2e85794

	} else {
	result.alternateText = lastMessageTextFromReport.length > 0 ? lastMessageText : ReportActionsUtils.getLastVisibleMessage(report.reportID, {}, lastAction)?.lastMessageText;
	if (!result.alternateText) {
	result.alternateText = Localize.translate(preferredLocale, 'report.noActivityYet');
	}
	}

What changes do you think we should make in order to solve the problem?

We need the clear the lastMessageText for the report from the onyx's optimisticData in the resolveActionableReportMentionWhisper function.

....
{
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${reportId}`,
    value: {lastMessageText: ''},
},
...

[melvin-bot]

@strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Confirmed reproducible. Doesn't update on a refresh either.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0150a19511c968b1de

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)